Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]visibility for the selected options and filters improvements #43

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

bizzappdev
Copy link

Changed things in this PR.

…on option when we change filter from maturity to version etc.
@bizzappdev bizzappdev changed the title [FIX]visibility for the selection options and filters improvements [FIX]visibility for the selected options and filters improvements Nov 21, 2018
@bizzappdev
Copy link
Author

@elicoidal @sbidoul @oscarolar @RoelAdriaans if you can review.

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please bump version number

@bizzappdev
Copy link
Author

@elicoidal Version number changed.

@elicoidal
Copy link

@bizzappdev I do not see the version number in github. Are you sure?

@bizzappdev
Copy link
Author

indeed it was the wrong branch. now it is there

@elicoidal elicoidal merged commit 7cca07a into OCA:11.0 Nov 23, 2018
@elicoidal
Copy link

@sbidoul please deploy

@sbidoul
Copy link
Member

sbidoul commented Nov 23, 2018

deployed

@elicoidal
Copy link

@bizzappdev it seems #41 is not fixed after deployment. Can you have a look?

@bizzappdev
Copy link
Author

bizzappdev commented Nov 23, 2018

@elicoidal indeed it is working at the level of filter we have added but not at the level of Options provided by Odoo on the right side.
selection_007

@elicoidal
Copy link

my feeling is: we do not need anymore the left part: confusing, not providing better information (now duplicated) and removing valuable screen space.
So I consider this topic successfully closed!

@elicoidal
Copy link

image

victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 30, 2019
…A#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 2, 2019
…A#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 6, 2019
…A#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number
Tardo pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 5, 2020
…A#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number
pedrobaeza pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 12, 2020
update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

Fix Bad rendering of links inside README (OCA#42)

* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view

[FIX]visibility for the selected options and filters improvements (OCA#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number

[FIX]CSS module description

[FIX]website_apps_store: fix the shop pager

[FIX][49] solve pager with search parameter (OCA#51)

Sort by Download and rating (OCA#46)

* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated

11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

[FIX] website product page event not define problem

[FIX]fix 403 public user error

[FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 16, 2021
update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

Fix Bad rendering of links inside README (OCA#42)

* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view

[FIX]visibility for the selected options and filters improvements (OCA#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number

[FIX]CSS module description

[FIX]website_apps_store: fix the shop pager

[FIX][49] solve pager with search parameter (OCA#51)

Sort by Download and rating (OCA#46)

* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated

11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

[FIX] website product page event not define problem

[FIX]fix 403 public user error

[FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 24, 2021
update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

Fix Bad rendering of links inside README (OCA#42)

* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view

[FIX]visibility for the selected options and filters improvements (OCA#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number

[FIX]CSS module description

[FIX]website_apps_store: fix the shop pager

[FIX][49] solve pager with search parameter (OCA#51)

Sort by Download and rating (OCA#46)

* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated

11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

[FIX] website product page event not define problem

[FIX]fix 403 public user error

[FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants