Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bad rendering of links inside README #42

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Fix Bad rendering of links inside README #42

merged 3 commits into from
Nov 20, 2018

Conversation

bizzappdev
Copy link

@bizzappdev bizzappdev commented Nov 13, 2018 •
edited
Loading

we added CSS/LESS to hide the initial unwanted space. which was causing the problem for hiding add the content which has a reference as a class.
fixed it by providing only first document class
FIX of #37 as well as

@pedrobaeza pedrobaeza modified the milestones: 10.0, 11.0 Nov 13, 2018
@sbidoul
Copy link
Member

sbidoul commented Nov 13, 2018

@bizzappdev thanks for this. I deployed it to test, but it seems something else is wrong. I don't see the correct readme:

image

@bizzappdev
Copy link
Author

@sbidoul initially the sequence for the variant was another way. like first 7.0 then 8.0 and so on.
So we have changed the default content display as per the minimum sequence of the variant.

Please let me know the sequence of the attribute values and I will incldue the fix in this branch itself

@sbidoul
Copy link
Member

sbidoul commented Nov 13, 2018

@bizzappdev I'm not sure what you mean. In my mind, the selected version and repository link must match, and the readme displayed must correspond to the selected version.

@pedrobaeza
Copy link
Member

I think the problem here is that the README is shown at template level, which means one per module, not per version (which is a product variant).

@sbidoul
Copy link
Member

sbidoul commented Nov 13, 2018

It's not only the readme. The repository link is wrong too (see in my screenshot above).

@pedrobaeza
Copy link
Member

Well, the same explanation. What you see there is the template data. I'm not sure if it's easy to change that.

@bizzappdev
Copy link
Author

@sbidoul @pedrobaeza when then product page has been loaded it selects the first variant. BUT it is not updating the product_variant_id.
and in that case, product_vairant_id is not where it should display the default values from one of the product variants.
so in this repo's custom code, it is like the variant with minimum sequence attribute will be treated as default variant.
that is why it is right now displaying the 7.0 values.

there can be 2 solutions for this.

  1. either somehow we set the default selected variant in product_variant_id.
  2. or provide the default values based on the max sequence of the attribute.

@pedrobaeza
Copy link
Member

@bizzappdev but if you change the selected variant, all that data is updated?

@bizzappdev
Copy link
Author

@bizzappdev but if you change the selected variant, all that data is updated?

yes if we select manually the variant then it will automatically have a proper value from that variant.
the problem is just when the product page has been loaded and no manual action has been done

@pedrobaeza
Copy link
Member

OK, I see. Then what to do?

@bizzappdev
Copy link
Author

@pedrobaeza let me trace the sequence how it has been disply the variant list on page same way we can have default one.

elicoidal
elicoidal reviewed Nov 13, 2018
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would bump version number.
Shall we open another issue for the product variant mismatch?
Other than that, LGTM

@bizzappdev
Copy link
Author

@pedrobaeza soled the problem. make the sorting for default version same as website template.

@elicoidal sorry I missed your comment and committed in same branch. can we still take care for merge as the merge is still not done.

elicoidal
elicoidal approved these changes Nov 20, 2018
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I let you follow up for new PR

@elicoidal elicoidal merged commit ad88a94 into OCA:11.0 Nov 20, 2018
@elicoidal
Copy link

@sbidoul can you deploy? Thanks

@bizzappdev bizzappdev mentioned this pull request Nov 21, 2018
Closed
@sbidoul
Copy link
Member

sbidoul commented Nov 21, 2018

@elicoidal @bizzappdev deploy done

@elicoidal
Copy link

@bizzappdev

image

There is no rendered README now: is there a latency due to cron job running?

Side note: MIS-builder is available in v12 but I cannot see the version in the download options.

@sbidoul
Copy link
Member

sbidoul commented Nov 23, 2018

@elicoidal

MIS-builder is available in v12

It is not. (installable=False)

victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 10, 2019
@bizzappdev
Fix Bad rendering of links inside README (OCA#42)
83e7715 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request Apr 30, 2019
@bizzappdev
Fix Bad rendering of links inside README (OCA#42)
7c1c2e7 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 2, 2019
@bizzappdev
Fix Bad rendering of links inside README (OCA#42)
cdc87fd 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
victormmtorres pushed a commit to Tecnativa/apps-store that referenced this pull request May 6, 2019
@bizzappdev
Fix Bad rendering of links inside README (OCA#42)
61394e1 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
CarlosRoca13 pushed a commit to Tecnativa/apps-store that referenced this pull request Jul 10, 2020
@bizzappdev @CarlosRoca13
Fix Bad rendering of links inside README (OCA#42)
47e0afd 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
pedrobaeza pushed a commit to Tecnativa/apps-store that referenced this pull request Jul 17, 2020
@bizzappdev @pedrobaeza
Fix Bad rendering of links inside README (OCA#42)
e41ccf1 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
Tardo pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 5, 2020
@bizzappdev @Tardo
Fix Bad rendering of links inside README (OCA#42)
8c3d107 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
pedrobaeza pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 12, 2020
@bizzappdev @pedrobaeza
[FIX+IMP] website_apps_store: Several fixes and improvements:
60c4712 
update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

Fix Bad rendering of links inside README (OCA#42)

* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view

[FIX]visibility for the selected options and filters improvements (OCA#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number

[FIX]CSS module description

[FIX]website_apps_store: fix the shop pager

[FIX][49] solve pager with search parameter (OCA#51)

Sort by Download and rating (OCA#46)

* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated

11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

[FIX] website product page event not define problem

[FIX]fix 403 public user error

[FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 2, 2021
@bizzappdev
Fix Bad rendering of links inside README (OCA#42)
1b5a249 
* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 16, 2021
@bizzappdev
[FIX+IMP] website_apps_store: Several fixes and improvements:
40a26cb 
update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

Fix Bad rendering of links inside README (OCA#42)

* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view

[FIX]visibility for the selected options and filters improvements (OCA#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number

[FIX]CSS module description

[FIX]website_apps_store: fix the shop pager

[FIX][49] solve pager with search parameter (OCA#51)

Sort by Download and rating (OCA#46)

* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated

11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

[FIX] website product page event not define problem

[FIX]fix 403 public user error

[FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56
ernestotejeda pushed a commit to Tecnativa/apps-store that referenced this pull request Aug 24, 2021
@bizzappdev
[FIX+IMP] website_apps_store: Several fixes and improvements:
8121fad 
update products attributes and create attribute values (OCA#40)

* [FIX]update the product for the new version

* [FIX]max version problem and also rewrite logic so the from fronend if the version is not selected manually then the default(with less sequence) will be downloaded

* [IMP]added technical name search functionality

* change version number

* [IMP]Merged create and update product cron job

* [FIX]fix variable names

Fix Bad rendering of links inside README (OCA#42)

* [FIX][OCA#37]fix rendering from README

* [ADD]added CONTRIBUTORS

* [FIX] Sorting problem. sorted(for getting default version) as similar as it is sorted from website view

[FIX]visibility for the selected options and filters improvements (OCA#43)

* [FIX]visibility for the selection options and do not loss the selection option when we change filter from maturity to version etc.

* [VER]Added Version number

[FIX]CSS module description

[FIX]website_apps_store: fix the shop pager

[FIX][49] solve pager with search parameter (OCA#51)

Sort by Download and rating (OCA#46)

* [WIP] added initial support for Google recaptcha

* [WIP]added dependencies

* [IMP]Added google captcha with download functionality with reset and validation

* [IMP]added download count fields and increament it when donwloaded

* [ADD]added missing files

* [IMP]website_apps_store: add sort by download count on website

* remove console and not extra space

* [VER]changed version number

* [FIX]website_apps_store: fix test case error

* [FIX]reset only if google recaptcha is initiated

11.0 issue OCA#50 add the module technical name in front page (OCA#52)

* [FIX][49] solve pager with search parameter

* [IMP]website_apps_store : add technical name in front page

* [IMP]website_apps_store : add website tour to search technical name

* [FIX]website_apps_store : add demo/product_template_demo.xml in menifest.py

[FIX] website product page event not define problem

[FIX]fix 403 public user error

[FIX]website_apps_store: attribute value change was not changing the href for the repository. OCA#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bizzappdev @sbidoul @pedrobaeza @elicoidal @OCA-git-bot