[15.0][IMP] account_payment_order*: Define the correct date in the files that are generated. #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jul 8, 2024
…at are generated. Compatibility with OCA#1297 The payment (account.payment) and the account entry (account.move) are defined with today's date, but the "important" date is the date of the line, therefore the payment_line_date field is created. The modules account_banking_sepa_sepa_direct_debit + account_banking_sepa_credit_transfer to use the payment_line_date field. TT49988
victoralmau
force-pushed
the
15.0-imp-account_payment_order-TT49988
branch
from
ae07a37
to
80b99ac
Compare
pedrobaeza
approved these changes
Jul 8, 2024
|
@carlosdauden this is the reason why the previous payment date was set to the requested date, but let's have both things through this extra field in |
sergio-teruel
approved these changes
Jul 8, 2024
|
Let's patch the problem ASAP: /ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f065dbd. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the correct date in the files that are generated.
Compatibility with #1297
The payment (
account.payment) and the account entry (account.move) are defined with today's date, but the "important" date is the date of the line, therefore thepayment_line_datefield is created.The modules
account_banking_sepa_sepa_direct_debit+account_banking_sepa_credit_transferto use the payment_line_date field.The modules
l10n_es_payment_order_confirming_aef+l10n_es_payment_order_confirming_sabadellof OCA/l10n-spain do not need these changes because they do not usepayment_ids.Please @pedrobaeza can you review it?
@Tecnativa TT49988