[13.0][ADD] account_bank_statement_import_oca_camt54: #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschanzt
approved these changes
Jan 16, 2020
i-vyshnevska
force-pushed
the
13-account_bank_statement_import_camt54
branch
from
8ee8615
to
c179bb9
Compare
extension logic for account_bank_statement_import_camt_oca
i-vyshnevska
force-pushed
the
13-account_bank_statement_import_camt54
branch
from
f91db70
to
520fde7
Compare
i-vyshnevska
changed the title
i-vyshnevska
changed the title
i-vyshnevska
force-pushed
the
13-account_bank_statement_import_camt54
branch
2 times, most recently
from
bed1ba5
to
d9cd8c2
Compare
i-vyshnevska
force-pushed
the
13-account_bank_statement_import_camt54
branch
from
d9cd8c2
to
41a531a
Compare
|
functional test ok |
fclementic2c
approved these changes
Feb 7, 2020
Tonow-c2c
approved these changes
Feb 7, 2020
| def _complete_stmts_vals(self, stmts_vals, journal, account_number): | ||
| """Search partner from partner reference""" | ||
| stmts_vals = super()._complete_stmts_vals(stmts_vals, journal, account_number) | ||
| for st_vals in stmts_vals: |
There was a problem hiding this comment.
I don't really how it can be optimized
stmts_vals will be returned as a result eventually and this is just dict not orm model
| found_node = node.xpath(xpath_expr, namespaces={"ns": ns}) | ||
| if found_node: | ||
| name = found_node[0].text | ||
| break |
There was a problem hiding this comment.
can you just comment this with functional explanation
|
This PR has the |
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Feb 7, 2020
|
Congratulations, your PR was merged at 01c4592. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension logic for account_bank_statement_import_camt_oca
UPD addon to create aditional line in statement account_bank_statement_import_transfer_move