Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] product_brand: Migration to 14.0 #58

Merged
merged 36 commits into from
Dec 23, 2020

Conversation

joao-p-marques
Copy link
Member

Superseeds #51

@Tecnativa
TT26444

ping @pedrobaeza @chienandalu

bguillot and others added 30 commits December 17, 2020 11:29
* add smart button, move menu to a more visible position.
* show brand in product.template kanban and tree views.
* show brand in product variant kanban and tree views.
* add product_brand kanban view.
* update module's README and manifest file.
* Search and group by brand for both product.product and product.template.
* Convert model to new APIs.
* Refactor products_count computation using product_ids one2many field.
* Add public read access to product.brand (fixes 403 error on webshop for public user).
* Make brand name required.
Old form view was out of order: form blocks misaligned, because it was
not using Odoo 10 views styling and layout.
Lookup fails when the ID is formatted. The unformatted version of the
data is located under `raw_value`.
Currently translated at 100,0% (21 of 21 strings)

Translation: product-attribute-11.0/product-attribute-11.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/
… with other odoo apps. (#364)

* Make the logo always the same width (64px).
* Remove the description (200 first caracters). Not relevant for a configuration model.
* Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/
Currently translated at 37.5% (9 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested on runbot. Only non-blocking comments.

product_brand/reports/account_invoice_report.py Outdated Show resolved Hide resolved
product_brand/reports/account_invoice_report.py Outdated Show resolved Hide resolved
product_brand/readme/ROADMAP.rst Show resolved Hide resolved
product_brand/readme/USAGE.rst Outdated Show resolved Hide resolved
@joao-p-marques joao-p-marques force-pushed the 14.0-mig_product_brand branch 2 times, most recently from 3d801e7 to edc8bef Compare December 18, 2020 07:43
Co-authored-by: Bejaoui Souheil <souheil_bejaoui@hotmail.fr>

TT26444
@joao-p-marques
Copy link
Member Author

Changes made @Tardo

@joao-p-marques joao-p-marques changed the title [14.0][MIG] migration product_brand: Migration to 14.0 [14.0][MIG] product_brand: Migration to 14.0 Dec 18, 2020
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza pedrobaeza added this to the 14.0 milestone Dec 23, 2020
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-58-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5d3fdd7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.