Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] Migration of product_brand #90

Merged
merged 46 commits into from
Feb 1, 2022

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Nov 29, 2021

Proposed changes

Migration PR for module product_brand.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

bguillot and others added 30 commits November 29, 2021 14:31
* add smart button, move menu to a more visible position.
* show brand in product.template kanban and tree views.
* show brand in product variant kanban and tree views.
* add product_brand kanban view.
* update module's README and manifest file.
* Search and group by brand for both product.product and product.template.
* Convert model to new APIs.
* Refactor products_count computation using product_ids one2many field.
* Add public read access to product.brand (fixes 403 error on webshop for public user).
* Make brand name required.
Old form view was out of order: form blocks misaligned, because it was
not using Odoo 10 views styling and layout.
Lookup fails when the ID is formatted. The unformatted version of the
data is located under `raw_value`.
Currently translated at 100,0% (21 of 21 strings)

Translation: product-attribute-11.0/product-attribute-11.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/
… with other odoo apps. (#364)

* Make the logo always the same width (64px).
* Remove the description (200 first caracters). Not relevant for a configuration model.
* Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/
Currently translated at 37.5% (9 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/
Currently translated at 100.0% (24 of 24 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_brand
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/
@alan196 alan196 mentioned this pull request Nov 29, 2021
16 tasks
@pedrobaeza
Copy link
Member

/ocabot migration product_brand

@pedrobaeza
Copy link
Member

@sbidoul it seems the bot is stalled

@sbidoul
Copy link
Member

sbidoul commented Nov 30, 2021

Some issue with the github token again... can you retry ?

@pedrobaeza
Copy link
Member

/ocabot migration product_brand

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 30, 2021
@pedrobaeza
Copy link
Member

Now it's working, thanks

Copy link

@ibraimFer ibraimFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration is very important

Copy link

@olveracuenca olveracuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full functional and technical review

Copy link

@MiguelJarsa MiguelJarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

Copy link

@marco1esparza marco1esparza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete migration to version 15.0, good implementation

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbejaoui
Copy link
Contributor

sbejaoui commented Feb 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-90-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 750a6de into OCA:15.0 Feb 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c034f11. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 15.0-mig-product_brand branch February 14, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.