[8.0][IMP] Transfer the Gross Profit fields to the Deliverable lines #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicoidal
suggested changes
Apr 2, 2017
| ) | ||
|
|
||
| @api.multi | ||
| @api.depends('resource_ids.price_total', |
There was a problem hiding this comment.
I am not sure this does what I am expecting.
Here is what I need: DL.gross_profit = DL.price_total - sum(RL.cost)
It should be updated whenever the RL.cost or DL.price_total changes.
Can you double check? @sudhir-serpentcs
| @@ -31,6 +31,9 @@ | |||
| class="oe_highlight"/> | |||
| </group> | |||
| </xpath> | |||
| <xpath expr="//field[@name='price_total']" position="after"> | |||
| <field name="gross_profit"/> | |||
There was a problem hiding this comment.
Not only: I would like to see the same fields as in the BR (check screenshot that I have provided).
Besides it should only be visible to the "cost" group
sudhir-serpentcs
force-pushed
the
8.0-19850-BR000801-Transfer_GrossProfit_fields_to_DL
branch
from
23b7a38
to
a59e162
Compare
|
@elicoidal |
|
@sudhir-serpentcs please check this and the screenshot. The current code doesnot cover it all AFAIK. |
|
please follow: #84 |
sudhir-serpentcs
force-pushed
the
8.0-19850-BR000801-Transfer_GrossProfit_fields_to_DL
branch
from
ee3a5b2
to
2ec7427
Compare
sudhir-serpentcs
force-pushed
the
8.0-19850-BR000801-Transfer_GrossProfit_fields_to_DL
branch
from
80c6251
to
1e82d67
Compare
|
@elicoidal @victormartinelicocorp |
elicoidal
approved these changes
Apr 11, 2017
|
Will need to be fixed when #113 is finished |
|
@sudhir-serpentcs can you rebase your work to fit the changes made in #113 |
|
@sudhir-serpentcs once you fix the link to #113 we could quickly merge |
|
@sudhir-serpentcs #113 is fixed. Can you rebase and fix this one? |
|
@elicoidal |
|
@sudhir-serpentcs I have lost the description field in deliverable |
|
@elicoidal |
|
@sudhir-serpentcs far from been ready: can you retest the full process? When creating a RL in the DL, I have following js error: Error: NameError: name 'business_requirement_id' is not defined |
|
@elicoidal |
ruter-lyu
pushed a commit
to ruter-lyu/business-requirement
that referenced
this pull request
Mar 20, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 4, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 6, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 6, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
pedrobaeza
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 21, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 21, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 21, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 26, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jun 26, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jul 25, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Aug 9, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victormmtorres
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Aug 19, 2019
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jan 24, 2020
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code.
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Jan 27, 2020
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Mar 3, 2020
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Mar 5, 2020
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
Tardo
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Mar 30, 2020
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Oct 14, 2021
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code. OCA Transbot updated translations from Transifex
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Oct 14, 2021
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code. OCA Transbot updated translations from Transifex
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Nov 11, 2021
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Nov 15, 2021
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
victoralmau
pushed a commit
to Tecnativa/business-requirement
that referenced
this pull request
Nov 15, 2021
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
MosabWadea
pushed a commit
to MosabWadea/business-requirement
that referenced
this pull request
Mar 5, 2022
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code. OCA Transbot updated translations from Transifex
MosabWadea
pushed a commit
to MosabWadea/business-requirement
that referenced
this pull request
Mar 5, 2022
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
bizzappdev
pushed a commit
to BizzAppDev-Systems/business-requirement
that referenced
this pull request
Mar 4, 2023
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
AntoniRomera
pushed a commit
to AntoniRomera/business-requirement
that referenced
this pull request
Jul 4, 2023
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code. OCA Transbot updated translations from Transifex
dreispt
pushed a commit
to dreispt/business-requirement
that referenced
this pull request
Apr 27, 2024
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
1 task
dreispt
pushed a commit
to dreispt/business-requirement
that referenced
this pull request
Apr 27, 2024
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes.
NachoAlesLopez
pushed a commit
to NachoAlesLopez/business-requirement
that referenced
this pull request
Apr 28, 2024
…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code. OCA Transbot updated translations from Transifex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer the Gross Profit fields to the Deliverable lines.
BR with BRD_cost give the calculation for Total Revenue-Total Cost = Gross Profit
Need to have on every DL the same calculation based on their own RL
So DL 1 will have a partial Total Revenue DL 1 - Total Cost DL 1 = Gross Profit DL 1
@elicoidal