[ADD][business_requirement] Added To be reviewed field in BR #120

sudhir-serpentcs · 2017-04-14T14:03:54Z

@victormartinelicocorp @elicoidal
Added to be reviewed field with filter and grouping

elicoidal · 2017-04-15T02:02:13Z

sudhir-serpentcs · 2017-04-15T07:23:07Z

@elicoidal @victormartinelicocorp
Improved form view as per requirement.
please review code.

elicoidal · 2017-04-16T00:44:28Z

@sudhir-serpentcs

Revenue in the tree view has disappeared and no total (obviously).
Rest of modifications are good!

Additional details:

created on => Creation Date
Created By and Creation Date should be on the same line (the 2 columns should be well aligned)
move linked project in the same line as priority (it will disappear later anyway)

sudhir-serpentcs · 2017-04-17T12:36:17Z

@elicoidal @victormartinelicocorp
can you please review code.

elicoidal · 2017-04-17T14:03:49Z

Thanks @sudhir-serpentcs still missing the revenue and total in the tree view.

elicoidal · 2017-04-18T01:10:25Z

@sudhir-serpentcs there is very few left for this one. If you can fix it we could merge it quickly

elicoidal · 2017-04-20T01:40:30Z

@sudhir-serpentcs there is very few left for this one. If you can fix it we could merge it quickly

Can you proceed so that we finish the roll-out?

sudhir-serpentcs · 2017-04-21T06:55:01Z

@elicoidal sure I will.

elicoidal · 2017-04-26T07:18:58Z

@sudhir-serpentcs I did not pay attention but some comments are duplicated in #105

victormmtorres · 2017-04-27T06:23:06Z

@sudhir-serpentcs I did not pay attention but some comments are duplicated in #105

@sudhir-serpentcs Fix or modify business_requirement_deliverable only on #105

@elicoidal Once this PR only apply for the module business_requirement I think is ready to merge

victormmtorres · 2017-04-28T05:12:54Z

@sudhir-serpentcs I did not pay attention but some comments are duplicated in #105

@elicoidal Could you specify what is no need to be implemented here?

serpentcs-dev1 · 2017-04-28T05:49:43Z

@elicoidal

Yes the comments is covered in the PR #105

Now I think all comments are fulfilled and it is ready to merge once reviewed.

cc @victormartinelicocorp

elicoidal · 2017-04-28T07:05:45Z

@victormartinelicocorp this one could be merge right?

victormmtorres · 2017-04-28T07:22:31Z

business_requirement_deliverable/models/business.py

@@ -236,7 +236,7 @@ class BusinessRequirement(models.Model):
    total_revenue = fields.Float(
        compute='_compute_deliverable_total',
        string='Total Revenue',
-        store=False
+        store=True


@sudhir-serpentcs This change is duplicated with https://github.com/OCA/business-requirement/pull/105/files#diff-005420dbf67a67f7fbc633822129feceL280

Please remove from this PR. The rest LGTM

cc @elicoidal

@sudhir-serpentcs once this is fixed, I will merge

elicoidal · 2017-04-28T08:14:02Z

@sudhir-serpentcs you will probably need to rebase given all modifications ;)

elicoidal · 2017-04-28T09:59:27Z

@victormartinelicocorp Let's move on

* [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code.

…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code.

…CA#105) * [IMP] Transfer the Gross Profit fields to the Deliverable lines * [IMP] Changed calculation for Gross Profit. * [IMP]Transfer the Gross Profit fields to the Deliverable lines * [ADD]Added Description field * [IMP] Improved code as per comment. * [IMP]changed the position of the fields. * [IMP] Improved code as per comment. * [IMP]Improved pivot views. * [FIX] Fixed Travis & Changed code as per comments. * [FIX] made requested changes. [ADD][business_requirement] Added To be reviewed field in BR (OCA#120) * [ADD]Added To be reviewed field in BR * [IMP] Improved form view as per requirement. * [IMP] Improved code as per comment. * [FIX] Fixed issues. * [IMP]Improved Code. * [IMP] IMproved code. OCA Transbot updated translations from Transifex

[ADD]Added To be reviewed field in BR

1ab145a

elicoidal added the needs review label Apr 15, 2017

elicoidal added needs fixing and removed needs review labels Apr 15, 2017

[IMP] Improved form view as per requirement.

493438a

[IMP] Improved code as per comment.

d5b56a4

sudhir-serpentcs force-pushed the 8.0-13787_BR000189_Improve-Reviewer-information branch 2 times, most recently from 0d2f5fa to a864cb4 Compare April 18, 2017 12:37

[FIX] Fixed issues.

a864cb4

[IMP]Improved Code.

5bac362

sudhir-serpentcs added 2 commits April 24, 2017 15:24

[IMP] IMproved code.

86dc9ee

[FIX] Resolved conflict.

de02e9b

elicoidal changed the title ~~[ADD]Added To be reviewed field in BR~~ [ADD][business_requirement] Added To be reviewed field in BR Apr 26, 2017

elicoidal added this to the 8.0 milestone Apr 26, 2017

elicoidal approved these changes Apr 28, 2017

View reviewed changes

elicoidal added needs review and removed needs fixing labels Apr 28, 2017

victormmtorres suggested changes Apr 28, 2017

View reviewed changes

seb-elico approved these changes Apr 28, 2017

View reviewed changes

Merge branch '8.0' into 8.0-13787_BR000189_Improve-Reviewer-information

92521e8

victormmtorres approved these changes Apr 28, 2017

View reviewed changes

elicoidal merged commit e4d686b into OCA:8.0 Apr 28, 2017

sudhir-serpentcs deleted the 8.0-13787_BR000189_Improve-Reviewer-information branch July 11, 2017 05:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][business_requirement] Added To be reviewed field in BR #120

[ADD][business_requirement] Added To be reviewed field in BR #120

sudhir-serpentcs commented Apr 14, 2017 •

edited

Loading

elicoidal commented Apr 15, 2017 •

edited

Loading

sudhir-serpentcs commented Apr 15, 2017

elicoidal commented Apr 16, 2017 •

edited

Loading

sudhir-serpentcs commented Apr 17, 2017

elicoidal commented Apr 17, 2017

elicoidal commented Apr 18, 2017

elicoidal commented Apr 20, 2017

sudhir-serpentcs commented Apr 21, 2017

elicoidal commented Apr 26, 2017

victormmtorres commented Apr 27, 2017

victormmtorres commented Apr 28, 2017

serpentcs-dev1 commented Apr 28, 2017

elicoidal commented Apr 28, 2017

victormmtorres Apr 28, 2017

elicoidal Apr 28, 2017

elicoidal commented Apr 28, 2017

elicoidal commented Apr 28, 2017

[ADD][business_requirement] Added To be reviewed field in BR #120

[ADD][business_requirement] Added To be reviewed field in BR #120

Conversation

sudhir-serpentcs commented Apr 14, 2017 • edited Loading

elicoidal commented Apr 15, 2017 • edited Loading

sudhir-serpentcs commented Apr 15, 2017

elicoidal commented Apr 16, 2017 • edited Loading

sudhir-serpentcs commented Apr 17, 2017

elicoidal commented Apr 17, 2017

elicoidal commented Apr 18, 2017

elicoidal commented Apr 20, 2017

sudhir-serpentcs commented Apr 21, 2017

elicoidal commented Apr 26, 2017

victormmtorres commented Apr 27, 2017

victormmtorres commented Apr 28, 2017

serpentcs-dev1 commented Apr 28, 2017

elicoidal commented Apr 28, 2017

victormmtorres Apr 28, 2017

Choose a reason for hiding this comment

elicoidal Apr 28, 2017

Choose a reason for hiding this comment

elicoidal commented Apr 28, 2017

elicoidal commented Apr 28, 2017

sudhir-serpentcs commented Apr 14, 2017 •

edited

Loading

elicoidal commented Apr 15, 2017 •

edited

Loading

elicoidal commented Apr 16, 2017 •

edited

Loading