[IMP][BR_deliverable] Added Smart Buttons and Search views for DL and RL

[sudhir-serpentcs]

@victormartinelicocorp @elicoidal

Added Smart buttons for Resource Lines and Deliverble Lines also added Search views

[elicoidal]

Please fix travis

[elicoidal]

@sudhir-serpentcs

Here is the result of my initial functional tests:

• You should remove the tab "Deliverable" from BR
• The access rules from [8.0][IMP] Changed Workflow for business requirements. #103 should still be valid
• Smart buttons should indicate how many RL and DL are available

In DL tree view:

• remove Currency
• Add BR (in place of currency)

In DL Form View

• Currency should be after the total
• BR field should be before the product
• Have 2 columns:
  • first one with BR+Product+Qty+unit+sales Price+total+currency
  • second: Name
• In RL sub form: remove the root task category field ( @victormartinelicocorp not sure about the usage)
• In RL sub form: hide the BR field

In RL Tree view

• Move the BR in first place
• Add the DL after the BR

No tests on prices yet.

[sudhir-serpentcs]

@elicoidal @victormartinelicocorp
please review code

[elicoidal]

@sudhir-serpentcs thanks for the update, getting good.
I have updated comment #113 (comment) with progress.

Besides here are some new finding:
RL view:

• In RL tree view: should not see the task category field (To be ignored as the module will be removed later @victormartinelicocorp )
• in RL tree view: add the graph/pivot view
• In RL tree view, in the field, only the deliverable lines from the selected BR should appear
• In RL tree view you should not be able to select a BR if state is not draft/confirmed.

DL view

• in DL tree view: add the graph/pivot view
• In DL form view you should not be able to select a BR if state is not draft/confirmed.
• In DL, BR should be mandatory
• In DL, I cannot see anymore the cost and prices at RL level
• In DL, I cannot see anymore the Sales and prices at RL level
  In DL, I cannot see the fields Category (but this is maybe due to inheritence)

Misc:

• Add menu entry for Deliverable lines and Resources lines below BR entry

[victormmtorres]

@sudhir-serpentcs Not blocking but could you explain we is need to modify defaul_get?

[sudhir-serpentcs]

@victormartinelicocorp
will be removed from next commit

[victormmtorres]

@sudhir-serpentcs The same for this fields_view_get

[sudhir-serpentcs]

@victormartinelicocorp

access rules for #103

[victormmtorres]

@sudhir-serpentcs Please do the more specif you can the PR. I wish to see that on separated PR and for the proper module.

And by they way this could be done IMO simpler like is actually done:

Draft Confirmed Approved SH Appr. In prog
Cust. Story V X X X X
Actually works as the requirement see the states param

    business_requirement = fields.Html(
        'Customer Story',
        readonly=True,
        states={'draft': [('readonly', False)]}
    )

Do still think need to overwrite fields_view_get ?
I would call it editable rules instead of access rules

cc @elicoidal

[victormmtorres]

@sudhir-serpentcs Sorry but my comment for the unnecessary explanation.

I want to reformulate my question this it's done #103
What is exactly is fixed by overwrite the function?

[victormmtorres]

@sudhir-serpentcs Please do the more specif you can the PR. I wish to see that on separated PR and for the proper module.

And by they way this could be done IMO simpler like is actually done:

Draft Confirmed Approved SH Appr. In prog
Cust. Story V X X X X
Actually works as the requirement see the states param

    business_requirement = fields.Html(
        'Customer Story',
        readonly=True,
        states={'draft': [('readonly', False)]}
    )

Do still think need to overwrite fields_view_get ?
I would call it editable rules instead of access rules

cc @elicoidal

[sudhir-serpentcs]

@victormartinelicocorp I do agree with you but state field is not in the object. We need to make RL / DL R/O if BR is not in draft / confirmed state.

[victormmtorres]

@sudhir-serpentcs Thanks for the explanation

[sudhir-serpentcs]

@victormartinelicocorp @elicoidal
please review code

@victormartinelicocorp by mistake fields_view_get removed from #ebe0f96
so i have revised on next commit #e7f3596

[elicoidal]

@sudhir-serpentcs I have made some tests but only few has been updated. Check #113 (comment)

[elicoidal]

@pedrobaeza @dreispt let's know whether we can move on

[pedrobaeza]

Please squash by author and logical set before merging