[10.0]-[MIG]-Business requirement deliverable crm from v8 to v10 #229

YogeshMahera-SerpentCS · 2017-08-01T06:33:07Z

Issue #48

depends on [MIG]Migrated Business requirement module from 8.0 to 10.0 #223 [MIG]-Migrated Business Requirement Deliverable from 8.0 to 10.0. #224
Migrated Business requirement deliverable crm from v8 to 10

@elicoidal @victormartinelicocorp

…to 10.0-MIG-Business_requirement_deliverable_crm

elicoidal · 2017-09-13T10:38:58Z

#224 and #223 are merged: please rebase

…to 10.0-MIG-Business_requirement_deliverable_crm

YogeshMahera-SerpentCS · 2017-09-13T12:00:25Z

@elicoidal rebased

elicoidal

Functional tests are not successful:
How to reproduce: go to CRM opp Business Analysis. Click on button "Generate quotation from BR"
Expected behavior: a quotation is created based on deliverables
Current behavior: an error says there is no BR available.

Another issue: There is no link to the BR in the project (it should be the case in the business_requirement module)

elicoidal · 2017-09-14T09:18:56Z

business_requirement_deliverable_crm/__init__.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# © 2016 Elico Corp (https://www.elico-corp.com).
+# © 2017 Elico Corp (https://www.elico-corp.com).


2016-2017 everywhere

elicoidal · 2017-09-14T09:20:19Z

business_requirement_deliverable_crm/views/crm_view.xml

+        }</field>
+        <field name="help" type="html">
+            <p>
+                Odoo's project management allows you to manage the pipeline


Adapt (a text has been provided in business_requirement PR)

Adapted help text in PR #248

elicoidal · 2017-09-18T06:12:26Z

@YogeshMahera-SerpentCS is it good for tests?

elicoidal · 2017-09-18T06:21:52Z

One last detail: in deliverable form view, the Currency field should be after the total revenue field.

YogeshMahera-SerpentCS · 2017-09-18T12:45:54Z

Please check this.

elicoidal · 2017-09-19T01:14:12Z

No field to the BR in project:
can you recheck demo data with Opp "Business Analysis" linked to project "Business Analysis": I cannot create the SQ
not sure this is about this environment but all projects are duplicated.
Created a new Opp "TEST" associated to project "Corporate Website" and I cannot create the quotation.

Please recheck @YogeshMahera-SerpentCS

YogeshMahera-SerpentCS · 2017-09-19T11:12:00Z

@elicoidal

Could you please check it.

elicoidal · 2017-09-20T01:26:05Z

Creating quotation is fine but:

When updating the data in the BR0005. If I click in create quotation I should have a checkbox "Update quotation" like in v8. if BR changed, quotation is updated when selecting this box. Now even clicking on the button, the quotation is not updated (needs to delete manually the previous one)
Customer Reference field should contain the name of the BR

elicoidal · 2017-09-20T04:19:45Z

@victormartinelicocorp

victormmtorres · 2017-09-20T05:16:41Z

@YogeshMahera-SerpentCS Small details, here I found this on runbot:

2017-09-19 10:44:14,631 213 WARNING openerp_test odoo.models: crm.lead.create() includes unknown fields: ref

And just for curiosity about this change, may ask why?
https://github.com/OCA/business-requirement/pull/229/files#diff-ffb485409198eeea75ff84bfadc366fbL139

cc @elicoidal

YogeshMahera-SerpentCS · 2017-10-02T09:38:57Z

Still no field to the BR in project:
Regarding this point in Project module already defined BR field in Project
https://github.com/OCA/business-requirement/blob/10.0/business_requirement_deliverable_project/views/project.xml#L15

Other Points you can review it
@elicoidal

elicoidal · 2017-10-02T15:05:36Z

Runbot is not running: I will merge and we will test locally

elicoidal · 2017-10-02T15:09:44Z

Tested: LGTM

…#229) * [MIG]Migrated Module * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code * [IMP]Improved code for demo data * [IMP]Improveed License code * [IMP]Improved code in xml * [IMP]Imprved demo data,Removed duplicate data * [IMP]Improved code for update quatation * [IMP]Improved code for update quatation * [IMP]Improved BR button postion in CRM * [IMP]Improved code * [IMP]Fixed issue of pricelist comes from BR * [IMP]Improved changes * [IMP]Imprroved code * [IMP]Imprroved code * [IMP]Imprroved code * [IMP]Imprroved code

YogeshMahera-SerpentCS added 6 commits July 31, 2017 18:51

[MIG]Migrated Module

a3dbb6a

[IMP]Improved code

f838a76

[IMP]Improved code

b6735f9

[IMP]Improved code

bcf13c5

[IMP]Improved code

c1cb27e

Merge branch '10.0' of https://github.com/OCA/business-requirement in…

37622fb

…to 10.0-MIG-Business_requirement_deliverable_crm

elicoidal added this to the 10.0 milestone Aug 4, 2017

elicoidal added the work in progress label Aug 4, 2017

pedrobaeza mentioned this pull request Aug 4, 2017

Migration to version 10.0 [FINISHED] #48

Closed

14 tasks

[IMP]Improved code for demo data

91b126c

Merge branch '10.0' of https://github.com/OCA/business-requirement in…

036cf23

…to 10.0-MIG-Business_requirement_deliverable_crm

elicoidal suggested changes Sep 14, 2017

View reviewed changes

YogeshMahera-SerpentCS mentioned this pull request Sep 16, 2017

[PR-REF 225-229]-[IMP]-Improved demo data file and added group in dl total revenue #248

Merged

YogeshMahera-SerpentCS added 2 commits September 18, 2017 11:00

[IMP]Improveed License code

ca11560

[IMP]Improved code in xml

f50a284

elicoidal added needs review and removed work in progress labels Sep 18, 2017

[IMP]Imprved demo data,Removed duplicate data

03f4f2b

elicoidal mentioned this pull request Sep 20, 2017

[10.0]-[MIG]-Migrated Business requirement deliverable project from v8 to 10 #231

Merged

[IMP]Improved code for update quatation

477394e

YogeshMahera-SerpentCS added 2 commits October 2, 2017 14:37

[IMP]Imprroved code

e96b8b7

[IMP]Imprroved code

27f2b22

elicoidal merged commit d943baa into OCA:10.0 Oct 2, 2017

elicoidal removed the needs review label Oct 2, 2017

dreispt mentioned this pull request Apr 27, 2024

[15.0][MIG] business_requirement_deliverable: Migration to 15.0 #380

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0]-[MIG]-Business requirement deliverable crm from v8 to v10 #229

[10.0]-[MIG]-Business requirement deliverable crm from v8 to v10 #229

YogeshMahera-SerpentCS commented Aug 1, 2017 •

edited

Loading

elicoidal commented Sep 13, 2017

YogeshMahera-SerpentCS commented Sep 13, 2017

elicoidal left a comment

elicoidal Sep 14, 2017

elicoidal Sep 14, 2017

YogeshMahera-SerpentCS Sep 18, 2017

elicoidal commented Sep 18, 2017

elicoidal commented Sep 18, 2017

YogeshMahera-SerpentCS commented Sep 18, 2017

elicoidal commented Sep 19, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Sep 19, 2017

elicoidal commented Sep 20, 2017 •

edited

Loading

elicoidal commented Sep 20, 2017

victormmtorres commented Sep 20, 2017

YogeshMahera-SerpentCS commented Oct 2, 2017 •

edited

Loading

elicoidal commented Oct 2, 2017

elicoidal commented Oct 2, 2017

[10.0]-[MIG]-Business requirement deliverable crm from v8 to v10 #229

[10.0]-[MIG]-Business requirement deliverable crm from v8 to v10 #229

Conversation

YogeshMahera-SerpentCS commented Aug 1, 2017 • edited Loading

elicoidal commented Sep 13, 2017

YogeshMahera-SerpentCS commented Sep 13, 2017

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal Sep 14, 2017

Choose a reason for hiding this comment

elicoidal Sep 14, 2017

Choose a reason for hiding this comment

YogeshMahera-SerpentCS Sep 18, 2017

Choose a reason for hiding this comment

elicoidal commented Sep 18, 2017

elicoidal commented Sep 18, 2017

YogeshMahera-SerpentCS commented Sep 18, 2017

elicoidal commented Sep 19, 2017 • edited Loading

YogeshMahera-SerpentCS commented Sep 19, 2017

elicoidal commented Sep 20, 2017 • edited Loading

elicoidal commented Sep 20, 2017

victormmtorres commented Sep 20, 2017

YogeshMahera-SerpentCS commented Oct 2, 2017 • edited Loading

elicoidal commented Oct 2, 2017

elicoidal commented Oct 2, 2017

YogeshMahera-SerpentCS commented Aug 1, 2017 •

edited

Loading

elicoidal commented Sep 19, 2017 •

edited

Loading

elicoidal commented Sep 20, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Oct 2, 2017 •

edited

Loading