9.0 16334 migrate business requirement #25

sudhir-serpentcs · 2016-09-23T11:06:43Z

Migrated business_requirement module from v8 to v9.
@dreispt @pedrobaeza @jbeficent @moylop260 Please review.

elicoidal

some details in README . 👍

elicoidal · 2016-09-23T11:54:12Z

business_requirement/README.rst

+
+.. figure:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/222/8.0


elicoidal · 2016-09-23T11:55:18Z

business_requirement/README.rst

+   .. figure:: ../business_requirement/static/img/bus_req_tags2.png
+      :width: 600 px
+
+   .. figure::business_requirement/static/img/bus_req_tags2.png


For all pictures, keep only one remove business_requirement/

elicoidal · 2016-09-23T11:56:01Z

business_requirement/models/business.py

+    @api.model
+    def _get_default_company(self):
+        company_id = self.env.user._get_company()
+        if not company_id:


I think this should never happen as company is mandatory.

Yes, I do agree with you.
I will remove it.

elicoidal · 2016-09-24T01:26:03Z

tested in runbot: 👍

moylop260 · 2016-09-24T02:21:19Z

business_requirement/models/business.py

+    company_id = fields.Many2one(
+        'res.company', string='Company',
+        required=True, readonly=True, states={'draft': [('readonly', False)]},
+        default=_get_default_company,


What about use the following way https://github.com/odoo/odoo/blob/b2804b1d2ae5fd7ec5c0eca79a8db77476badc84/addons/account/models/account.py#L192?

company_id = fields.Many2one('res.company', string='Company', required=True, index=True, default=lambda self: self.env.user.company_id, help="Company related to this journal")

… to get default Company.

sudhir-serpentcs · 2016-09-26T07:32:22Z

Removed duplicate images from README and added anonymous function to get default company.

sudhir-serpentcs · 2016-09-26T07:33:39Z

Next: Replace old screenshots in README by new ones for v9.

elicoidal · 2016-09-26T10:27:32Z

True and add some simple demo data as well ( @sudhir-serpentcs )

elicoidal · 2016-09-29T07:18:54Z

@sudhir-serpentcs demo data can be done in second stage. Can you resubmit with newer screenshot so that we have it reviewed and merged?

moylop260 · 2016-09-24T02:23:44Z

business_requirement/models/business.py

+    @api.multi
+    @api.onchange('project_id')
+    def project_id_change(self):
+        if self.project_id and self.project_id.partner_id:


What about use:

- if self.project_id and self.project_id.partner_id: - self.partner_id = self.project_id.partner_id.id + self.partner_id = self.project_id.partner_id.id

Now the new api support BrowseNull.BrowseNull and IMHO this onchange should change in order to avoid use a old value of other onchange.

moylop260 · 2016-09-24T02:32:00Z

business_requirement/models/business.py

+    _name = "business.requirement.category"
+    _description = "Categories"
+
+    name = fields.Char(string='Name', required=True)


FYI https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#field
If the technical name of the field (the variable name) is the same to the string of the label, don't put string parameter for new API fields, because it's automatically taken

…ter for the fields.

sudhir-serpentcs · 2016-09-30T13:21:46Z

Replaced old screenshots with new ones, removed string parameters from the fields.

…ment Code review based on OCA guidelines

sudhir-serpentcs · 2016-10-04T10:02:51Z

Merged the PR of Astirpe.

elicoidal · 2016-10-04T12:00:53Z

business_requirement/README.rst

+More information about business requirements management:
+
+* `Wikipedia <https://en.wikipedia.org/wiki/Business_requirements>`_
+* `Six Sigma <(https://www.isixsigma.com/implementation/project-selection-tracking/business-requirements-document-high-level-review/>`_


remove "(" in URL

Fixes

Update README.rst

Flake8: openerp.api not used

…case-field [IMP]business_requirement: add test case field

Porting of latest developments made in V8

Porting of latest developments made in V8. Updated Contributors list

Restored the period, I removed it by mistake

…ment_patch1 [9.0] business_requirement: Porting of latest developments made in V8

astirpe · 2016-10-21T12:16:49Z

Code review 👍

elicoidal

small details. Other than that 👍

elicoidal · 2016-10-21T14:43:44Z

business_requirement/models/business_requirement.py

+            ('draft', 'Draft'),
+            ('confirmed', 'Confirmed'),
+            ('approved', 'Approved'),
+            ('stakeholder_approval', 'Stakeholder Approval'),


stakeholder_approved, Stakeholder Approved

@elicoidal in V8 the states values have stakeholder_approval, we should be careful when changing this item. It also implies to create migration scripts.

Maybe changing only the string 'Stakeholder Approved' would be enough?

Agree. Let's just change the name

sudhir-serpentcs#9

elicoidal · 2016-10-21T14:44:36Z

business_requirement/models/business_requirement.py

+                     attachments=None, context=None,
+                     content_subtype='html', **kwargs):
+        subject = None
+        if context.get(


formatting is a little bit weird but non blocking

'Stakeholder Approval' -> 'Stakeholder Approved'

astirpe · 2016-10-21T15:46:04Z

business_requirement/models/business_requirement.py

+
+    @api.multi
+    def action_button_stakeholder_approval(self):
+        self.state = 'stakeholder_approval'


Modification not required anymore, changing the name sudhir-serpentcs#9 is enough

Update business_requirement.py

dreispt · 2016-12-02T16:44:32Z

@moylop260 @elicoidal Are there still any blocking points?

elicoidal · 2016-12-28T10:52:24Z

@dreispt sorry for the delay, just catching up.
I think this is safe to merge.

sudhir-serpentcs added 2 commits September 23, 2016 16:22

[ADD] Migrated business_requirement module from v8 to v9.

5e11278

[ADD] Added travis status in README.

feef370

elicoidal suggested changes Sep 23, 2016

View reviewed changes

elicoidal mentioned this pull request Sep 23, 2016

Migration to version 9.0 #20

Closed

8 tasks

sudhir-serpentcs mentioned this pull request Sep 24, 2016

[ADD] Migrated business_requirement_deliverable module from v8 to v9. #26

Merged

moylop260 reviewed Sep 24, 2016

View reviewed changes

[IMP] Removed duplicate images from README and added anonymous method…

22a0c64

… to get default Company.

sudhir-serpentcs mentioned this pull request Sep 28, 2016

[9.0][ADD] Added BR Deliverable Default business_requirement_deliverable_default module for v9. #27

Merged

elicoidal added the needs review label Sep 29, 2016

moylop260 requested changes Sep 29, 2016

View reviewed changes

[IMP] Added screenshots of v9 in README and removed the string parame…

7f74804

…ter for the fields.

elicoidal mentioned this pull request Sep 30, 2016

[IMP]business_requirement: add test case field #28

Merged

astirpe and others added 2 commits October 4, 2016 10:26

Code review based on OCA guidelines

ad302d9

Merge pull request #1 from astirpe/9.0-16334-migrate_business_require…

cdc7357

…ment Code review based on OCA guidelines

elicoidal suggested changes Oct 4, 2016

View reviewed changes

astirpe and others added 4 commits October 4, 2016 16:12

Flake8: openerp.api not used

6c5cef0

Update README.rst

6de5767

Fixes

Merge pull request #5 from astirpe/patch-3

a3c774e

Update README.rst

Merge pull request #4 from astirpe/patch-2

1ac18a6

Flake8: openerp.api not used

RawEvan mentioned this pull request Oct 9, 2016

9.0 business requirement add test case field #50

Closed

RawEvan and others added 6 commits October 11, 2016 11:53

[IMP]business_requirement: add test case field

0bd9c6a

Merge pull request #6 from RawEvan/9.0-business-requirement-add-test-…

7744b86

…case-field [IMP]business_requirement: add test case field

Update business_requirement.py

3359bd4

Porting of latest developments made in V8

Update README.rst

c04553e

Porting of latest developments made in V8. Updated Contributors list

Update README.rst

f388607

Restored the period, I removed it by mistake

Merge pull request #8 from astirpe/9.0-16334-migrate_business_require…

2a6cd7f

…ment_patch1 [9.0] business_requirement: Porting of latest developments made in V8

elicoidal suggested changes Oct 21, 2016

View reviewed changes

Update business_requirement.py

74a1963

'Stakeholder Approval' -> 'Stakeholder Approved'

astirpe reviewed Oct 21, 2016

View reviewed changes

Merge pull request #9 from astirpe/patch-1

bd6b94b

Update business_requirement.py

moylop260 approved these changes Dec 2, 2016

View reviewed changes

elicoidal merged commit c3099ac into OCA:9.0 Dec 28, 2016

sudhir-serpentcs deleted the 9.0-16334-migrate_business_requirement branch February 9, 2017 06:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9.0 16334 migrate business requirement #25

9.0 16334 migrate business requirement #25

sudhir-serpentcs commented Sep 23, 2016 •

edited

Loading

elicoidal left a comment

elicoidal Sep 23, 2016

elicoidal Sep 23, 2016

elicoidal Sep 23, 2016

sudhir-serpentcs Sep 26, 2016

elicoidal commented Sep 24, 2016

moylop260 Sep 24, 2016

sudhir-serpentcs commented Sep 26, 2016

sudhir-serpentcs commented Sep 26, 2016

elicoidal commented Sep 26, 2016

elicoidal commented Sep 29, 2016

moylop260 Sep 24, 2016

moylop260 Sep 24, 2016

sudhir-serpentcs commented Sep 30, 2016

sudhir-serpentcs commented Oct 4, 2016

elicoidal Oct 4, 2016

astirpe commented Oct 21, 2016

elicoidal left a comment

elicoidal Oct 21, 2016

astirpe Oct 21, 2016

elicoidal Oct 21, 2016

astirpe Oct 21, 2016

elicoidal Oct 21, 2016

astirpe Oct 21, 2016

dreispt commented Dec 2, 2016

elicoidal commented Dec 28, 2016

9.0 16334 migrate business requirement #25

9.0 16334 migrate business requirement #25

Conversation

sudhir-serpentcs commented Sep 23, 2016 • edited Loading

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal commented Sep 24, 2016

Choose a reason for hiding this comment

sudhir-serpentcs commented Sep 26, 2016

sudhir-serpentcs commented Sep 26, 2016

elicoidal commented Sep 26, 2016

elicoidal commented Sep 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhir-serpentcs commented Sep 30, 2016

sudhir-serpentcs commented Oct 4, 2016

Choose a reason for hiding this comment

astirpe commented Oct 21, 2016

elicoidal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreispt commented Dec 2, 2016

elicoidal commented Dec 28, 2016

sudhir-serpentcs commented Sep 23, 2016 •

edited

Loading