[ADD] Migrated business_requirement_deliverable module from v8 to v9. #26
Conversation
|
Travis failed only because business_requirement module is not found. |
|
@sudhir-serpentcs you will have to rebase when the other module is merged. |
|
You can also cherry-pick/merge the other PR in your branch for this to work, and rebase as said by Eric when the other PR is merged. |
|
👍 no test yet / waiting for the first PR to be accepted |
| _name = "business.requirement.resource" | ||
| _description = "Business Requirement Resource" | ||
|
|
||
| sequence = fields.Integer('Sequence') |
There was a problem hiding this comment.
FYI https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#field
If the technical name of the field (the variable name) is the same to the string of the label, don't put string parameter for new API fields, because it's automatically taken
(check other similar cases for this PR)
| @@ -0,0 +1,78 @@ | |||
| language: python | |||
There was a problem hiding this comment.
probably not need as it is already in the first PR
| @@ -1,2 +1,5 @@ | |||
| # business-requirement | |||
| [](https://travis-ci.org/OCA/business-requirement) | |||
There was a problem hiding this comment.
same here: proably not needed
| Resources for your customers', | ||
| 'version': '9.0.1.0.0', | ||
| 'website': 'www.elico-corp.com', | ||
| "author": "Elico Corp, Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Change double quotation to single quotation
| self.br.write({'partner_id': self.partner.id}) | ||
| try: | ||
| self.br.partner_id_change() | ||
| except UserError, e: |
There was a problem hiding this comment.
flake8 returns this error:
business_requirement_deliverable/tests/test_br.py:247:26: E901 SyntaxError: invalid syntax
Could you check?
…deliverable [FIX] Resource lines under Deliverables lines tab
|
@sudhir-serpentcs Travis is red. Can you fix it? |
|
@sudhir-serpentcs can you recheck travis? |
|
@dreispt @gurneyalex |
|
You could try update this branch from 9.0 to get the merged commits |
…o 9.0-migrate_business_requirement_deliverable
|
Travis is green as #25 is merged and this PR is rebased. |
|
👍 |
| @api.onchange('product_id') | ||
| def product_id_change(self): | ||
| description = '' | ||
| uom_id = False |
There was a problem hiding this comment.
What about use directly self.uom_id in order to avoid create a dummy variable?
| for resource in self: | ||
| if resource.resource_type == 'task' and ( | ||
| resource.uom_id.category_id != ( | ||
| self.env.ref('product.uom_categ_wtime'))): |
There was a problem hiding this comment.
If we delete categories we don't want a raise here:
- self.env.ref('product.uom_categ_wtime')
+ self.env.ref('product.uom_categ_wtime', raise_if_not_found=False)| partner_id = brd.business_requirement_id.partner_id | ||
| if partner_id and partner_id.property_product_pricelist: | ||
| return partner_id.property_product_pricelist | ||
| return partner_id |
There was a problem hiding this comment.
The method is called _get_pricelist but we are returning a partner_id
| def _get_pricelist(self): | ||
| for brd in self: | ||
| partner_id = False | ||
| if brd.business_requirement_id and ( |
| for brd in self: | ||
| partner_id = False | ||
| if brd.business_requirement_id and ( | ||
| brd.business_requirement_id.partner_id |
There was a problem hiding this comment.
You could use just brd.business_requirement_id.partner_id (without brd.business_requirement_id) because new api supports BrowseNull.BrowseNull
| @api.multi | ||
| @api.onchange('product_id') | ||
| def product_id_change(self): | ||
| description = '' |
There was a problem hiding this comment.
What about use directly self.variables?
…//github.com/sudhir-serpentcs/business-requirement into 9.0-migrate_business_requirement_deliverable
|
@moylop260 @astirpe Have made the necessary requested changes. Please review and approve. |
|
Can we merge? |
|
I would say so! |
|
@dreispt @pedrobaeza Any idea why the travis Transfex is failing? |
sudhir-serpentcs
deleted the
9.0-migrate_business_requirement_deliverable
branch
|
The problem is with Transifex. Are all the invoices paid up? 😁 |
|
obviously no t :p |
WIP until #25 is merged
Migrated business_requirement_deliverable module from v8 to v9.
@dreispt @pedrobaeza @jbeficent @moylop260 Please review.