[9.0][ADD] Migrated business_requirement_deliverable_cost module from v8 to v9 #30
Conversation
| Introduction | ||
| ============ | ||
|
|
||
| This module is part of a set of modules (`Business Requirements <https://github.com/OCA/business-requirement/blob/8.0/README.md>`_) |
| "business_requirement_deliverable", | ||
| ], | ||
| 'image': [ | ||
| 'static/description/icon.png', |
…erable_categ Cleansed the README+__openerp__.py
…o 9.0-migrate_business_requirement_deliverable_cost
|
Rebased the PR. |
| br_id = False | ||
| if self.business_requirement_deliverable_id: | ||
| br_deliverable = self.business_requirement_deliverable_id | ||
| if br_deliverable and br_deliverable.business_requirement_id: |
There was a problem hiding this comment.
Please apply the same fix that was made for V8 in https://github.com/OCA/business-requirement/pull/66/files
There was a problem hiding this comment.
@sudhir-serpentcs Can you attend @astirpe recommendation so that we can merge cleanly?
There was a problem hiding this comment.
@astirpe @elicoidal Done
elicoidal
changed the title
|
@astirpe @sudhir-serpentcs can we merge this one? |
|
I think yes. We can merge it. |
|
With commit 6ebfc4b the method |
|
agree with @astirpe indeed. |
|
@elicoidal @astirpe Replaced the _get_partner() method by related partner_id field. |
| for resource in self: | ||
| resource.sale_price_total = resource.sale_price_unit * resource.qty | ||
|
|
||
| # @api.multi |
There was a problem hiding this comment.
please remove dead codes
|
|
||
| <record id="group_business_requirement_estimation" model="res.groups"> | ||
| <field name="name">Business Requirement Estimation</field> | ||
| <field name="implied_ids" eval="[(4, ref('business_requirement.group_business_requirement_user'))]"/> |
There was a problem hiding this comment.
Can you improve the format of the lines for readibility?
|
@elicoidal @astirpe Removed dead code and improved security xml. |
sudhir-serpentcs
deleted the
9.0-migrate_business_requirement_deliverable_cost
branch
WIP until #25 and #26 is merged
Migrated business_requirement_deliverable_cost module from v8 to v9.
WIP: Clean up of unit test cases.
@dreispt @pedrobaeza @jbeficent @moylop260 Please review.