-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][FIX] api decorator on module sale_commission #111
Conversation
Please check Travis status |
I don't understand why of the errors on the tests, it is not due to this change, could be another module that has change and Interfere on tests? |
Well, it's an error on this module, so do this:
|
@pedrobaeza I don't understand the error. is the same in this PR #109 |
But it's the error also on the main branch? |
By main branch you refer 8.0, don't you? |
Yeah, that's what I mean, so the problem is not due to your change. Maybe you can investigate why it happens and in what commit it started to fail? |
OK, let's merge this one, although the branch is still red and anyone should fix it. |
The method "_refund_cleanup_lines" in odoo is defined like "def _refund_cleanup_lines(self, lines)" and should be decoreted with @api.model instead of @api.multi