Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][FIX] api decorator on module sale_commission #111

Merged
merged 1 commit into from
Dec 28, 2016

Conversation

nicomacr
Copy link

The method "_refund_cleanup_lines" in odoo is defined like "def _refund_cleanup_lines(self, lines)" and should be decoreted with @api.model instead of @api.multi

@pedrobaeza
Copy link
Member

Please check Travis status

@jjscarafia
Copy link

I don't understand why of the errors on the tests, it is not due to this change, could be another module that has change and Interfere on tests?

@pedrobaeza
Copy link
Member

Well, it's an error on this module, so do this:

  • Check first if the error is also on the main branch.
  • If not, run the tests locally to debug the problem.

@nicomacr
Copy link
Author

nicomacr commented Dec 27, 2016

@pedrobaeza I don't understand the error. is the same in this PR #109
, #108

@pedrobaeza
Copy link
Member

But it's the error also on the main branch?

@nicomacr
Copy link
Author

By main branch you refer 8.0, don't you?
8.0 also falling due to same error, check here https://travis-ci.org/OCA/commission/branches

@pedrobaeza
Copy link
Member

Yeah, that's what I mean, so the problem is not due to your change. Maybe you can investigate why it happens and in what commit it started to fail?

@pedrobaeza
Copy link
Member

OK, let's merge this one, although the branch is still red and anyone should fix it.

@pedrobaeza pedrobaeza merged commit be09367 into OCA:8.0 Dec 28, 2016
@nicomacr nicomacr deleted the 8.0-fix_sale_commission branch December 28, 2016 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants