Porting of module sale commission formula to Version 10.0

[hurrinico]

this one depends on

• sale_commission: [MIG] sale_commission: Migrated to 10.0 #117

[pedrobaeza]

Please squash "OCA Transbot" commits together following https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

[hurrinico]

@pedrobaeza done

[eLBati]

@hurrinico please check lint

sale_commission_formula/__manifest__.py:6: [C8103(manifest-deprecated-key), ] Deprecated key "active" in manifest file
sale_commission_formula/__manifest__.py:6: [C8106(manifest-version-format), ] Wrong Version Format "8.0.1.0.0" in manifest

[rgarnau]

We have made an improvement for this PR in order to give more flexibility when defining the formula.
See hurrinico#3

[eLBati]

@rgarnau in commit 472b68d you are not recognized. Is the email address of that commit linked to your github account?

@hurrinico please squash merge commits (better not creating them directly while merging)

[rgarnau]

@eLBati To me, it looks like I am recognized in the commit (see image). I don't know what are you exactly referring to. The day before yesterday i changed the SSH key, maybe that's it...?

[eLBati]

@rgarnau If you were recognized, you wouldn't see the grey github cat.

See

You should first check if the email used for commit 472b68d is linked to your github account.

[pedrobaeza]

That's because the email address which was used for commiting is not registered to any GitHub account.

[rgarnau]

Yeah, rgarnau@gmail.com it's not my email address. Should I commit again with my email?

[pedrobaeza]

Well, that should be amended by the author of the PR

[rgarnau]

I just amended the author in my branch https://github.com/Eficent/commission/tree/10.0-Eficent-mig-sale_commission_formula but since this branch is not mine I cannot do it in here...

[lucode]

causes error "null value in column "access_token" from "website_quote" violates not-null constraint when this module is installed before.

[lucode]

I did try to run runbot again. The only reason of failed checks, seems to be the missing dependency of the module "sale_commission". But this should be ok as in the manifest file. The same module passes the test from my own PR 147. And there is a minor issue when the module should gets installed with Demo data. See me review.

[hurrinico]

@pedrobaeza @lucode @eLBati i have fixed tests and now travis is green

[pedrobaeza]

Please attend runbot warning:

sale.order.line.create() includes unknown fields: product_uos_qty

[hurrinico]

@pedrobaeza fixed :D