Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 porting sale_commission_pricelist #163

Merged
merged 4 commits into from
Aug 22, 2018

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented May 24, 2018

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request May 24, 2018
4 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone May 24, 2018
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try new README system by fragments.

@@ -9,6 +9,8 @@ Sales commissions by pricelist
This module extends the functionality of sale_commission to allow you set a
commission to pricelist item.

The discount will be applied when the pricelist rule will be applied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this means?

@@ -47,6 +49,7 @@ Contributors

* `Tecnativa <https://www.tecnativa.com>`_:
* Carlos Dauden
* Lorenzo Battistini <lorenzo.battistini@agilebg.com>

This comment was marked as resolved.

@eLBati eLBati force-pushed the 11.0-porting-sale_commission_pricelist branch from 2eee24e to 6e498ed Compare August 17, 2018 08:02
@eLBati
Copy link
Member Author

eLBati commented Aug 17, 2018

@pedrobaeza I created the new README

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking as migration is very straight-forward and it contains tests

@pedrobaeza pedrobaeza merged commit 2740d55 into OCA:11.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants