[FIX] sale_commission: Refunds from invoices. Fixes #51

[pedrobaeza]

When creating a refund from an invoice, pass correct values
(converted as dictionary) for the agents lines, so that the refund
keep the same commissions (but reversed) than the original invoice.

[pedrobaeza]

@ivantodorovich @oihane, please check this one.

[oihane]

Is it correct to do twice super?

[pedrobaeza]

We are not making super with the same argument. Take into account that this method serves as a cleaning method. We need to clean the data in the one2many field also. Odoo already calls this method several times (for the invoice line and for the tax lines).

[oihane]

After a quick test 👍

[pedrobaeza]

@ivantodorovich, can I get another positive review? Or @Daniel-CA, can you review this one?

[ivantodorovich]

@pedrobaeza shouldn't it also be inverting the commission line amount? to be consistent with #56

otherwise 👍 just tested it

[pedrobaeza]

It's not needed, as the negative amounts are obtained on the computed field, so the fields we pass are correct.

[oihane]

I did a quick test in runbot

• Customer invoice:
  
• Customer refund invoice:
  

@ivantodorovich does this solve your doubt?

[Daniel-CA]

That's fine for me. 👍

[ivantodorovich]

@oihane actually, no. Even if it's showing a negative commission on the invoice total, it's only negative there, the agent line's commission is still possitive.

So, when you make that settlement, you will be paying 600 $ to your agent. (300+300) instead of 0 (300-300)

But I'll see how it works with #56 and continue the work there if needed, since it's within its scope. I'm away for a few days that's why I didn't make much progress.

[ivantodorovich]

I stand corrected. It works perfectly! Sorry 😳