[12.0][MIG] connector_magento #292

sebalix · 2019-04-19T07:44:06Z

PR itself ready to be reviewed, but dependencies are not ready.

Depends on:

~~base_technical_user: [12.0][MIG] base_technical_user server-tools#1560~~
~~connector_ecommerce: [12.0][MIG] connector ecommerce connector-ecommerce#49~~
- ~~sale_exception: [12.0][MIG] sale_exception sale-workflow#831~~
  - ~~base_exception: [12.0][MIG] base_exception server-tools#1557~~
- ~~sale_automatic_workflow_payment_mode: [12.0][MIG] sale_automatic_workflow_payment_mode sale-workflow#786~~
  - ~~sale_automatic_workflow: [12.0][MIG] sale_automatic_workflow sale-workflow#830~~
  - ~~[BUG] account_payment_sale: [12.0][BUG] account_payment_sale bank-payment#536~~
    fixed by https://github.com/OCA/bank-payment/pull/630/files

oca_dependencies.txt has been updated to include all the dependencies and install the module on Travis.

Documentation generation is stuck because of this bug: odoo/odoo#28125
Don't know what to do about this, excepting disable the api/api_models part of the documentation (need to check if some other parts depend on it).
EDIT: I disabled the documentation for class members using fields as a workaround.

pedrobaeza · 2019-04-19T13:03:24Z

This is missing all the commit history in 10.0, as you are using a different starting branch.

pedrobaeza · 2019-04-19T13:05:07Z

Well, not all, but a part. Maybe it was added after the 11.0 PR. Please compare both.

sebalix · 2019-04-19T14:12:52Z

@pedrobaeza indeed, I tried to retrieve all previous commits when the module was still called magentoerpconnect but didn't succeed (doing two git format-patch, one for magentoerpconnect and one for connector_magento). I'll try again.

pedrobaeza · 2019-04-19T14:52:36Z

Well, I think it's enough with commits after renaming. I miss 2 o 3 only.

* Add binding on sales orders * Ensure that we always have the Connector Manager group on the Connector tabs (most are done in the parent views of connector_ecommerce) * Fixed inheritance of the delivery.carrier view

* Use vcr.py to record the exchanges instead of a self-made recorder * Use new base Components test case classes * Separate export tests in 2 phases: trigger of the export which check that the jobs are delayed, and test the job itself in a second test

I removed it earlier, but it is required when we import products

… on the wrong one

Unpacks the giftcard code from the PHP serialized information about the giftcards using regex.

Since the value will be a string like '0.0000', the prior tests were insufficient to prevent always adding a line.

* Rename it because it was shadowing another test * Compute in the location's context

sebalix · 2019-10-17T12:09:16Z

@rvalyi I rebased this branch to remove the pending merge on OCA/connector-ecommerce#49, it's ready to review/merge now.

JordiBForgeFlow · 2020-03-04T15:36:06Z

@sebalix hi! Have you evaluated the complexity to support Magento 2?

sebalix · 2020-03-06T08:49:46Z

@JordiBForgeFlow Hi! Not on latest versions of Odoo, but we are currently migrating this connector to Magento 2.2+ for OpenERP 7.0... :) (based on the work already started by @StefanRijnhart on Odoo 8.0 here: #289 ). I should take time to forward port some fixes in his PR BTW.
But nothing complex, a lot of code is reusable as-is, we mainly need to split ConnectorUnit/Component for each version to subclass a common one.

JordiBForgeFlow · 2020-03-12T13:08:06Z

@sebalix Have you seen this?

https://github.com/MindAndGo/connector-magento/tree/10.0-callino-rebase
https://github.com/wpichler/connector-magento/tree/10.0-callino-rebase

StefanRijnhart · 2020-03-27T12:46:37Z

connector_magento/tests/fixtures/cassettes/:w

@@ -0,0 +1,163 @@
+interactions:


I think this file was added unintendedly.

StefanRijnhart · 2020-03-27T13:03:58Z

Great work! I've got just the one comment.

StefanRijnhart · 2020-03-27T16:37:03Z

@sebalix please throw your fixes in my direction. I'll be starting to port Magento2 compatibility to 12.0 based to this branch if noone else is on it already (@JordiBForgeFlow?)

StefanRijnhart · 2020-04-04T08:36:24Z

@sebalix I took the liberty of removing this ':w' file myself and pushing it to your branch because that is the only flaw I could find this PR. Hoping we can merge it soon.

StefanRijnhart · 2020-04-06T10:03:07Z

Oh, I see runbot fails. Probably on these warnings:

2020-04-04 08:50:16,654 170 WARNING openerp_test odoo.models: The model magento.config.specializer has no _description
2020-04-04 08:50:16,660 170 WARNING openerp_test odoo.models: The model magento.binding.backend.read has no _description
2020-04-04 08:50:17,948 170 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (company, company_id) of res.partner() have the same label: Company.
2020-04-04 08:50:17,994 170 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (company_id, company) of magento.res.partner() have the same label: Company.
2020-04-04 08:50:18,054 170 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (company_id, company) of magento.address() have the same label: Company.
2020-04-04 08:50:18,148 170 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (product_variant_id, odoo_id) of magento.product.product() have the same label: Product.
2020-04-04 08:50:18,555 170 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (company, company_id) of res.users() have the same label: Company.
2020-04-04 08:50:19,167 170 WARNING openerp_test odoo.models: exception.rule.create() with unknown fields: rule_group
2020-04-04 08:50:19,173 170 WARNING openerp_test odoo.models: exception.rule.create() with unknown fields: rule_group
2020-04-04 08:50:19,957 170 WARNING openerp_test odoo.addons.base.models.ir_ui_view: The group base.group_multi_salesteams defined in view magento.storeview.form does not exist!

sebalix · 2020-04-06T11:13:26Z

@StefanRijnhart thank you for fixing this branch! Feel free to push on my branch to get it merged, I'm quite busy at the moment so I can't work on it sadly.

StefanRijnhart · 2020-04-06T14:44:10Z

Thanks, I'll have a look at the warnings then.

StefanRijnhart · 2020-04-06T17:49:12Z

Runbot green! Travis borked on failed nodejs download (and feedback missing in Github?) but previous run was green: https://travis-ci.org/github/OCA/connector-magento/builds/671728251

StefanRijnhart · 2020-04-06T17:54:39Z

@sebalix ~~on your review I will squash my fixes into your migration commit~~Guessing I will be prevented from force pushing the branch so please go ahead with squashing my fixes into your commit yourself.

sebalix

@StefanRijnhart I reviewed your commit, LG (but can't approve my own PR), feel free to squash your commits

connector_magento/tests/fixtures/cassettes/:w

sebalix · 2020-04-08T06:10:04Z

@JordiBForgeFlow a bit late sorry, no sadly I didn't see these branches until now.

StefanRijnhart · 2020-04-08T13:07:52Z

@sebalix thanks for the review. Can you squash my little commits into your migration commit?

StefanRijnhart · 2020-04-17T10:55:24Z

connector_magento/components/importer.py

+        for storeview in lang_storeviews:
+            lang_record = self._get_magento_data(storeview.external_id)
+            map_record = mapper.map_record(lang_record)
+            record = list(map_record.values())


Don't convert this dictionary of values to list. You can tell from line 320 that record needs to stay in dictionary format so that you can fetch its items()

StefanRijnhart · 2020-04-17T13:02:25Z

connector_magento/models/stock_picking/exporter.py

+        item_qty = {}
+        # get product and quantities to ship from the picking
+        for line in binding.move_lines:
+            sale_line = line.procurement_id.sale_line_id


sale_line = line.sale_line_id

pedrobaeza · 2020-07-02T14:31:07Z

@sebalix do you accept this to be superseded by #304 ?

sebalix · 2020-07-02T17:12:20Z

@StefanRijnhart @pedrobaeza sorry for the delay, yes of course, I'll close this one.

StefanRijnhart · 2020-07-02T17:42:07Z

Thanks, and thank you for your work on this @sebalix!

pedrobaeza added this to the 12.0 milestone Apr 19, 2019

OCA-git-bot mentioned this pull request Apr 19, 2019

Migration to version 12.0 #284

Open

1 task

sebalix force-pushed the 12.0-mig-connector_magento branch 2 times, most recently from 58b6e63 to 2acd90f Compare April 23, 2019 14:53

guewen and others added 22 commits April 24, 2019 09:25

Rename magentoerpconnect to connector_magento

1053a28

Restructure files, split large python files

7847595

Fix views

92196fb

* Add binding on sales orders * Ensure that we always have the Connector Manager group on the Connector tabs (most are done in the parent views of connector_ecommerce) * Fixed inheritance of the delivery.carrier view

Collection.work_on is now a context manager

b855485

Add a base listener and use it in partner export

508b97b

Update documentation

82dff57

Various fixes

bd17dde

Add dependency on product_multi_category

179dba2

I removed it earlier, but it is required when we import products

Manage multi-company backend

0634cdf

Fix Pylint warnings

c4120e0

Remove deprecated select for index creation

5f301bc

[FIX] pass http credentials to backedn component if required

59e4eec

[FIX] change user on backend otherwise import sale order will be done…

6e4148d

… on the wrong one

[CHG]review product aggregation by backend to improve performance

73551e2

Apply fiscal position

cbd4dea

Remove related_action from import_batch

a7cc720

Allow service type product based on 'giftcard' type in Magento.

7719275

Add Magento Enterprise Gift Cards payment line.

d47f3b0

Unpacks the giftcard code from the PHP serialized information about the giftcards using regex.

Don't add a 0 amount Giftcard line.

48a9b2a

Since the value will be a string like '0.0000', the prior tests were insufficient to prevent always adding a line.

Change return value matching with the comment

625e4c6

Fix failing test

2105381

* Rename it because it was shadowing another test * Compute in the location's context

sebalix force-pushed the 12.0-mig-connector_magento branch from cdcace8 to 6f3e828 Compare October 17, 2019 06:54

sebalix changed the title ~~[12.0][MIG][WIP] connector_magento~~ [12.0][MIG] connector_magento Oct 21, 2019

StefanRijnhart reviewed Mar 27, 2020

View reviewed changes

!fixup Were you trying to exit Vim?

c02b3d6

StefanRijnhart added 2 commits April 6, 2020 18:35

!fixup installation warnings

d9a0fe5

!fixup no traceback logging

3443355

StefanRijnhart approved these changes Apr 6, 2020

View reviewed changes

sebalix commented Apr 8, 2020

View reviewed changes

connector_magento/tests/fixtures/cassettes/:w Outdated Show resolved Hide resolved

StefanRijnhart reviewed Apr 17, 2020

View reviewed changes

StefanRijnhart self-requested a review April 17, 2020 13:03

StefanRijnhart mentioned this pull request May 8, 2020

Add/12.0/magento2 #304

Merged

sebalix closed this Jul 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] connector_magento #292

[12.0][MIG] connector_magento #292

sebalix commented Apr 19, 2019 •

edited

Loading

pedrobaeza commented Apr 19, 2019

pedrobaeza commented Apr 19, 2019

sebalix commented Apr 19, 2019

pedrobaeza commented Apr 19, 2019

sebalix commented Oct 17, 2019

JordiBForgeFlow commented Mar 4, 2020

sebalix commented Mar 6, 2020 •

edited

Loading

JordiBForgeFlow commented Mar 12, 2020

StefanRijnhart Mar 27, 2020

StefanRijnhart commented Mar 27, 2020

StefanRijnhart commented Mar 27, 2020

StefanRijnhart commented Apr 4, 2020

StefanRijnhart commented Apr 6, 2020

sebalix commented Apr 6, 2020

StefanRijnhart commented Apr 6, 2020

StefanRijnhart commented Apr 6, 2020

StefanRijnhart commented Apr 6, 2020 •

edited

Loading

sebalix left a comment •

edited

Loading

sebalix commented Apr 8, 2020

StefanRijnhart commented Apr 8, 2020

StefanRijnhart Apr 17, 2020

StefanRijnhart Apr 17, 2020

pedrobaeza commented Jul 2, 2020

sebalix commented Jul 2, 2020

StefanRijnhart commented Jul 2, 2020

[12.0][MIG] connector_magento #292

[12.0][MIG] connector_magento #292

Conversation

sebalix commented Apr 19, 2019 • edited Loading

pedrobaeza commented Apr 19, 2019

pedrobaeza commented Apr 19, 2019

sebalix commented Apr 19, 2019

pedrobaeza commented Apr 19, 2019

sebalix commented Oct 17, 2019

JordiBForgeFlow commented Mar 4, 2020

sebalix commented Mar 6, 2020 • edited Loading

JordiBForgeFlow commented Mar 12, 2020

StefanRijnhart Mar 27, 2020

Choose a reason for hiding this comment

StefanRijnhart commented Mar 27, 2020

StefanRijnhart commented Mar 27, 2020

StefanRijnhart commented Apr 4, 2020

StefanRijnhart commented Apr 6, 2020

sebalix commented Apr 6, 2020

StefanRijnhart commented Apr 6, 2020

StefanRijnhart commented Apr 6, 2020

StefanRijnhart commented Apr 6, 2020 • edited Loading

sebalix left a comment • edited Loading

Choose a reason for hiding this comment

sebalix commented Apr 8, 2020

StefanRijnhart commented Apr 8, 2020

StefanRijnhart Apr 17, 2020

Choose a reason for hiding this comment

StefanRijnhart Apr 17, 2020

Choose a reason for hiding this comment

pedrobaeza commented Jul 2, 2020

sebalix commented Jul 2, 2020

StefanRijnhart commented Jul 2, 2020

sebalix commented Apr 19, 2019 •

edited

Loading

sebalix commented Mar 6, 2020 •

edited

Loading

StefanRijnhart commented Apr 6, 2020 •

edited

Loading

sebalix left a comment •

edited

Loading