[MIG] contract_payment_mode: Migration to 11.0 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Copy partner payment mode to contracts when installing * Filter payment modes for sales * Adding tests
in recurring invoice
cubells
force-pushed
the
11.0-mig-contract_payment_mode
branch
from
089b845
to
9993b20
Compare
pedrobaeza
requested changes
May 17, 2018
contract_payment_mode/README.rst
Outdated
| @@ -51,6 +51,7 @@ Contributors | |||
| * Vicent Cubells <vicent.cubells@tecnativa.com> | |||
| * David Vidal <david.vidal@tecnativa.com> | |||
| * Carlos Dauden <carlos.dauden@tecnativa.com> | |||
| * Vicent Cubells <vicent.cubells@tecnativa.com> | |||
| # Copyright 2015 Domatix (<www.domatix.com>) | ||
| # Copyright 2016 Antiun Ingenieria S.L. - Antonio Espinosa | ||
| # Copyright 2017 Tecnativa - Vicent Cubells | ||
| # Copyright 2017 Tecnativa - David Vidal | ||
| # Copyright 2017 Tecnativa - Carlos Dauden <carlos.dauden@tecnativa.com> | ||
| # Copyright 2018 Tecnativa - Vicent Cubells <vicent.cubells@tecnativa.com> |
There was a problem hiding this comment.
Don't duplicate lines, but move your line to the bottom and put the year intervals
cubells
force-pushed
the
11.0-mig-contract_payment_mode
branch
from
9993b20
to
6867489
Compare
sergio-teruel
suggested changes
Jun 13, 2018
|
|
||
| @api.onchange('partner_id') | ||
| def on_change_partner_id(self): | ||
| if self.partner_id.customer_payment_mode_id: |
There was a problem hiding this comment.
Remove condition, if contract has a payment_mode and now the new customer selected has not one, the contract payyment_mode must be False
| @@ -0,0 +1,39 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Add missed tag utf-8
cubells
force-pushed
the
11.0-mig-contract_payment_mode
branch
from
6867489
to
f072447
Compare
|
@sergio-teruel @rafaelbn done! |
yajo
approved these changes
Jun 13, 2018
rafaelbn
approved these changes
Jun 13, 2018
There was a problem hiding this comment.
@sergio-teruel @pedrobaeza your comments have been attended.
Tested functionally 👍
pedrobaeza
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa