[11.0][MIG] contract_sale_generation #329

sylvainvh · 2019-05-14T10:59:08Z

Migration of module contract_sale_generation

I added the field contract_id on sale.order to replace the previous field journal_id

tbaden

thanks for the work 👍
I did a code review: LGTM,
but please use the new fragment readme
plus some optional changes if you like.

tbaden · 2019-05-15T17:37:23Z

contract_sale_generation/data/contract_cron.xml

+<?xml version="1.0" encoding='UTF-8'?>
+<odoo>
+
+    <record model="ir.cron" id="account_analytic_cron_for_sale">


optional change:
id before model

tbaden · 2019-05-15T17:42:07Z

contract_sale_generation/views/sale_view.xml

+        </field>
+    </record>
+
+    <record id="act_recurring_sales" model="ir.actions.act_window">


optional change:
action id pattern

For an action: the main action respects <model_name>_action. Others are suffixed with _, where detail is an underscore lowercase string explaining the action (should not be long). This is used only if multiple actions are declared for the model.

tbaden · 2019-05-15T17:42:47Z

contract_sale_generation/views/account_analytic_account_view.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+
+    <record id="account_analytic_account_recurring_sale_form" model="ir.ui.view">


optional change:
use original id (account_analytic_account_recurring_form_form)

luismontalba

Tested on runbot

sylvainvh · 2019-05-20T15:10:26Z

Hi @tbaden , @pedrobaeza and @luismontalba . I made required changes on my PR.

tbaden · 2019-05-20T15:15:21Z

contract_sale_generation/readme/USAGE.rst

+   * Sale Autoconfirm, validate Sales Orders if type is "Sales"
+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot


Runbot Button gets generated. Please remove this part from usage

tbaden

LGTM, please squash your commits into one. Thanks 👍

tbaden

Sorry, noticed you removed it from readme instead of usage. Readme gets generated by oca bot. You have to change the usage.rst

rafaelbn · 2019-05-27T15:00:08Z

Hello, this PR is duplicated there is a migration before in #320 made by @Bilbonet

rafaelbn · 2019-09-10T05:27:02Z

As I said this PR is duplicated. We should review previous one #320

pedrobaeza · 2019-12-17T00:08:20Z

/ocabot merge

OCA-git-bot · 2019-12-17T00:09:44Z

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-329-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-12-17T00:16:56Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-329-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2019-12-17T00:18:18Z

/ocabot merge

OCA-git-bot · 2019-12-17T00:18:31Z

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-329-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

flotho · 2019-12-17T00:19:02Z

contract_sale_generation/models/account_analytic_account.py

+        sale_line_vals.update({
+            'name': name,
+            'discount': line.discount,
+            'price_unit': line.price_unit,


In this part we're missing UOM . Is it possible to add this part https://github.com/OCA/contract/pull/284/files

OCA-git-bot · 2019-12-17T00:52:53Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-329-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2019-12-17T08:56:11Z

@sylvainvh can you attend @flotho's comment?

flotho · 2019-12-30T14:16:43Z

Hi @sylvainvh , any chance to have a review ?

Regards

flotho · 2019-12-30T14:56:15Z

Hi, @pedrobaeza ,

I propose a merge and I will propose a PR.

flotho · 2020-03-11T21:25:11Z

Hi @sylvainvh

Any chance to have a review on my PR on your repo ?
@pedrobaeza , do you recommend me to propose the same PR from sylvainvh#1 ?

pedrobaeza · 2020-03-12T07:53:23Z

If @sylvainvh doesn't answer in a while, you can supersede this PR with a new one starting from this and adding your extra commit.

Closes OCA#117

…ata (OCA#130) * [FIX+IMP] contract: Improve usability and don't fail on wrong data * Cron create invoices masked for avoiding silent errors * New constraints for assuring data consistency * UI helps for entering consistent data * Spanish translation * Remove double company_id field on form * [FIX] contract_sale_generation: Adapt tests to upstream contract

* Change the method called in the view * Complete the create_invoice method * Bump version + authoring * Correct bad call of method Small Documentation * Add super call in python test * FIX bad field names causing bad quantities in sale.order.line

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/gl/

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/de/

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/fi/

github-actions · 2021-11-14T12:13:47Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Syncing from upstream OCA/contract (15.0)

sylvainvh changed the title ~~11.0 mig contract sale generation~~ [11.0][MIG] contract_sale_generation May 15, 2019

tbaden suggested changes May 15, 2019

View reviewed changes

pedrobaeza mentioned this pull request May 17, 2019

[12.0] Create sale as Sales Order or Invoice option as per version 10 #332

Closed

luismontalba approved these changes May 20, 2019

View reviewed changes

tbaden suggested changes May 20, 2019

View reviewed changes

tbaden approved these changes May 20, 2019

View reviewed changes

OCA-git-bot added the approved label May 20, 2019

tbaden suggested changes May 20, 2019

View reviewed changes

OCA-git-bot removed the approved label May 20, 2019

sylvainvh force-pushed the 11.0-mig-contract_sale_generation branch from b38e03f to 4377a1d Compare May 20, 2019 15:31

max3903 added this to the 11.0 milestone May 22, 2019

sylvainvh force-pushed the 11.0-mig-contract_sale_generation branch from 4377a1d to 6d0007a Compare May 27, 2019 09:37

rafaelbn added the duplicate label May 27, 2019

rafaelbn mentioned this pull request Sep 10, 2019

[11.0] [MIG] contract_sale_generation #320

Closed

This was referenced Dec 17, 2019

Migration to version 12.0 #189

Closed

Migration to version 11.0 #101

Closed

OCA-git-bot added a commit that referenced this pull request Dec 17, 2019

Merge PR #329 into 11.0

146b2bc

Signed-off-by pedrobaeza

OCA-git-bot added a commit that referenced this pull request Dec 17, 2019

Merge PR #329 into 11.0

5bf1a8a

Signed-off-by pedrobaeza

flotho suggested changes Dec 17, 2019

View reviewed changes

flotho mentioned this pull request Jan 2, 2020

Add UOM correct usage sylvainvh/contract#1

Closed

angelmoya and others added 18 commits April 20, 2020 22:27

ADD contract_sale_generation module

b698749

[FIX] contract_sale_generation: Isolate sale generation (OCA#118)

75baba7

Closes OCA#117

OCA Transbot updated translations from Transifex

38b7822

[FIX] contract_payment_auto: Fix freze wkhtmltopdf freezed

79b36aa

[FIX] contract_sale_generation: Useless test

7da528f

OCA Transbot updated translations from Transifex

35fe442

OCA Transbot updated translations from Transifex

93d9e53

[UPD] Update contract_sale_generation.pot

c6e83da

[FIX] contract. Optimize insertion of dates in invoice and lines.

c1e289d

[UPD] Update contract_sale_generation.pot

1b24d0a

Update translation files

258f391

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (Galician)

eb36ca8

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/gl/

[ADD] icon.png

fe4865e

Translated using Weblate (German)

3b03245

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/de/

Translated using Weblate (Finnish)

3557e18

Currently translated at 100.0% (10 of 10 strings) Translation: contract-10.0/contract-10.0-contract_sale_generation Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/fi/

[MIG] contract_sale_generation: Migraiton to 11.0

250d26f

sylvainvh force-pushed the 11.0-mig-contract_sale_generation branch from 6d0007a to 250d26f Compare April 20, 2020 20:27

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 14, 2021

github-actions bot closed this Dec 19, 2021

BT-etejeda pushed a commit to BT-etejeda/contract that referenced this pull request May 17, 2024

Merge pull request OCA#329 from OCA/15.0

e3c74f5

Syncing from upstream OCA/contract (15.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] contract_sale_generation #329

[11.0][MIG] contract_sale_generation #329

sylvainvh commented May 14, 2019

tbaden left a comment

tbaden May 15, 2019

tbaden May 15, 2019

tbaden May 15, 2019

luismontalba left a comment

sylvainvh commented May 20, 2019

tbaden May 20, 2019

tbaden left a comment

tbaden left a comment

rafaelbn commented May 27, 2019 •

edited

rafaelbn commented Sep 10, 2019

pedrobaeza commented Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

pedrobaeza commented Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

flotho Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

pedrobaeza commented Dec 17, 2019

flotho commented Dec 30, 2019

flotho commented Dec 30, 2019

flotho commented Mar 11, 2020

pedrobaeza commented Mar 12, 2020

github-actions bot commented Nov 14, 2021

[11.0][MIG] contract_sale_generation #329

[11.0][MIG] contract_sale_generation #329

Conversation

sylvainvh commented May 14, 2019

tbaden left a comment

Choose a reason for hiding this comment

tbaden May 15, 2019

Choose a reason for hiding this comment

tbaden May 15, 2019

Choose a reason for hiding this comment

tbaden May 15, 2019

Choose a reason for hiding this comment

luismontalba left a comment

Choose a reason for hiding this comment

sylvainvh commented May 20, 2019

tbaden May 20, 2019

Choose a reason for hiding this comment

tbaden left a comment

Choose a reason for hiding this comment

tbaden left a comment

Choose a reason for hiding this comment

rafaelbn commented May 27, 2019 • edited

rafaelbn commented Sep 10, 2019

pedrobaeza commented Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

pedrobaeza commented Dec 17, 2019

OCA-git-bot commented Dec 17, 2019

flotho Dec 17, 2019

Choose a reason for hiding this comment

OCA-git-bot commented Dec 17, 2019

pedrobaeza commented Dec 17, 2019

flotho commented Dec 30, 2019

flotho commented Dec 30, 2019

flotho commented Mar 11, 2020

pedrobaeza commented Mar 12, 2020

github-actions bot commented Nov 14, 2021

rafaelbn commented May 27, 2019 •

edited