Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] [MIG] contract_sale_generation #320

Closed
wants to merge 18 commits into from
Closed

[11.0] [MIG] contract_sale_generation #320

wants to merge 18 commits into from

Conversation

Bilbonet
Copy link

@Bilbonet Bilbonet commented May 3, 2019

I fixed some problems in pr #147 and I use this module.
Maybe is possible to merge in branch 11.0

angelmoya and others added 15 commits February 17, 2018 17:46
@angelmoya @lk-eska
ADD contract_sale_generation module
ad89d5c
@angelmoya @lk-eska
[FIX] contract_sale_generation: Isolate sale generation (#118)
113b01c 
Closes #117
@oca-transbot @lk-eska
OCA Transbot updated translations from Transifex
f6376a8
@moylop260 @lk-eska
[FIX] contract_payment_auto: Fix freze wkhtmltopdf freezed
c7ba780
@pedrobaeza @lk-eska
[FIX] contract_sale_generation: Useless test
4fbcf60
@pedrobaeza @lk-eska
[10.0][FIX+IMP] contract: Improve usability and don't fail on wrong d…
d07a16e 
…ata (#130)

* [FIX+IMP] contract: Improve usability and don't fail on wrong data

* Cron create invoices masked for avoiding silent errors
* New constraints for assuring data consistency
* UI helps for entering consistent data
* Spanish translation
* Remove double company_id field on form

* [FIX] contract_sale_generation: Adapt tests to upstream contract
@oca-transbot @lk-eska
OCA Transbot updated translations from Transifex
0d2d9a7 
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
@lk-eska
[MIG] contract_sale_generation: Migration to 11.0
d1adfdd 
[MIG] contract_sale_generation: migration fix

[MIG] contract_sale_generation: migration fix test

[MIG] contract_sale_generation: migration fix test 2

another fix

fix test

last fix (I hope)
split only one module
2e7cc37
Merge branch '11.0-mig-contract_sale_generation' into OCA/contract/11.0
1eabb72
[FIX] some errors
b0076a0
Merge branch '11.0' of https://github.com/OCA/contract into 11.0
2f10871
Merge branch '11.0' of https://github.com/OCA/contract into 11.0
fa53c0f
Merge branch '11.0' of https://github.com/OCA/contract into 11.0
671ef6d
Merge branch '11.0' of https://github.com/OCA/contract into 11.0
bf9fe05
@oca-clabot
Copy link

Hey @Bilbonet, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Bilbonet
Copy link
Author

Bilbonet commented May 3, 2019

travis error seems related with module (contract_sale_invoicing).
I don't sure if is related with my changes in module (contract_sale_generation).

ERROR: test_contract_sale_invoicing_without (odoo.addons.contract_sale_invoicing.tests.test_contract_sale_invoicing.TestContractSaleInvoicing)
Traceback (most recent call last):
File "/home/travis/build/Bilbonet/contract/contract_sale_invoicing/tests/test_contract_sale_invoicing.py", line 43, in test_contract_sale_invoicing_without self.contract.recurring_create_invoice()
File "/home/travis/build/Bilbonet/contract/contract/models/account_analytic_account.py", line 313, in recurring_create_invoice invoices |= contract.with_context(ctx)._create_invoice()
File "/home/travis/build/Bilbonet/contract/contract_sale_invoicing/models/contract.py", line 32, in _create_invoice invoice=invoice)
TypeError: _create_invoice() got an unexpected keyword argument 'invoice' ERROR: test_sale_invoicing (odoo.addons.contract_sale_invoicing.tests.test_contract_sale_invoicing.TestContractSaleInvoicing) Traceback (most recent call last): File "/home/travis/build/Bilbonet/contract/contract_sale_invoicing/tests/test_contract_sale_invoicing.py", line 36, in test_sale_invoicing
self.contract.recurring_create_invoice() File "/home/travis/build/Bilbonet/contract/contract/models/account_analytic_account.py", line 313, in recurring_create_invoice
invoices |= contract.with_context(ctx)._create_invoice() File "/home/travis/build/Bilbonet/contract/contract_sale_invoicing/models/contract.py", line 32, in _create_invoice
invoice=invoice) TypeError: _create_invoice() got an unexpected keyword argument 'invoice'

@max3903 max3903 added this to the 11.0 milestone May 22, 2019
@rafaelbn rafaelbn mentioned this pull request May 27, 2019
Closed
@rafaelbn
Copy link
Member

Please @sylvainvh @luismontalba @tbaden we should review this PR before making a new one. Thanks

@tbaden
Copy link
Member

tbaden commented May 27, 2019

Added to my "to Review" list. Please check the travis state

luismontalba
luismontalba reviewed May 29, 2019
View reviewed changes
contract_sale_generation/models/account_analytic_account.py
return sale._convert_to_write(sale._cache)

@api.multi
def _create_invoice(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Travis error could be due to _prepare_invoice() method takes invoice as an argument in V11

@rafaelbn
Copy link
Member

Hi @Bilbonet thanks for this contribution.

Please could you please review this PR, rebase and review travis errors 🔴 ?

I think we should get this merged or if not pass to the next PR #329 😄

I will review at leat in OCA Code Sprint soon, thanks

@pedrobaeza
Copy link
Member

Closing as this one is red in favor of #329

@pedrobaeza pedrobaeza closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismontalba luismontalba luismontalba left review comments

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.