[9.0][FIX] contract_show_invoice: Error if create invoice with view context #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this change? It was OK before |
carlosdauden
commented
Aug 3, 2017
| @@ -3,26 +3,14 @@ | |||
| <data> | |||
|
|
|||
| <record id="act_analytic_invoices" model="ir.actions.act_window"> | |||
| <field name="context">{'search_default_analytic_account_ids': | |||
| [active_id], 'default_analytic_account_ids': active_id}</field> | |||
There was a problem hiding this comment.
@pedrobaeza this context is useless because analytic_account_ids is a computed field and the search is done by domain
There was a problem hiding this comment.
OK, but don't change the rest...
There was a problem hiding this comment.
For filtering the invoices with that analytic contract. It's the way to do it.
|
This module would not be better in analytic branch? |
|
Well, yes. And with other name even... |
carlosdauden
force-pushed
the
9.0-FIX-contract_show_invoice
branch
from
e098b4a
to
bd64837
Compare
carlosdauden
force-pushed
the
9.0-FIX-contract_show_invoice
branch
from
bd64837
to
7af3b76
Compare
That's best done in a next version migration (v10). |
|
hi @pedrobaeza , please take a look again. Thanks! |
pedrobaeza
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa