Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_financial_risk: Migration to version 16.0 #280

Merged
merged 39 commits into from
Jul 19, 2023

Conversation

stefan-tecnativa
Copy link

@stefan-tecnativa stefan-tecnativa commented Apr 25, 2023

cc @Tecnativa TT42783

@sergio-teruel please review!

Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@sergio-teruel
Copy link
Contributor

@stefan-tecnativa Add info in PR description about dependency of this PR (#272)

Copy link

@rp-landoo rp-landoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional approval

Copy link
Member

@gaikaz gaikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review (no changes)

@ellbristow
Copy link

#272 was closed, this now depends on #292 which has been merged. Can we trigger the tests to rerun as I believe this PR might be ready (and I need it for a project I'm working on :D )

@@ -0,0 +1 @@
odoo-addon-account_financial_risk @ git+https://github.com/OCA/credit-control.git@refs/pull/272/head#subdirectory=setup/account_financial_risk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
odoo-addon-account_financial_risk @ git+https://github.com/OCA/credit-control.git@refs/pull/272/head#subdirectory=setup/account_financial_risk
odoo-addon-account_financial_risk @ git+https://github.com/OCA/credit-control.git@refs/pull/292/head#subdirectory=setup/account_financial_risk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#272 was superseded by #292

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the notice, changed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellbristow if you are agree with the changes, can you aprove them? Thanks!

carlosdauden and others added 20 commits July 11, 2023 15:57
Currently translated at 7.7% (1 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/fr/
Currently translated at 7.7% (1 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt_BR/
Currently translated at 46.2% (6 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt_BR/
Currently translated at 23.1% (3 of 13 strings)

Translation: credit-control-12.0/credit-control-12.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-sale_financial_risk/pt/
…le_financial_risk:

 - Optimize code and change stored computed fields to not store to improve multi-company support
 - Improve multi-currency support
 - Convert risk amount fields to clickable link that shows traceability of amount origin
 - New pivot views to risk amount traceability
 - Simplify class style applied on risk fields
 - Migration script to remove old stored computed fields
 - Improve tests to cover new functionallity
 - Update translation files

account_financial_risk:
 - Don't block refund invoice validation when partner has risk exception
 - Allow search partners by risk exception field
 - Remove obsolete cron

sale_financial_risk
 - Create related store commercial_partner_id field in sale order line to simplify computation
 - Rename amt_to_invoice field to risk_amount in sale order line
 - Hook and migration scripts to reduce new fields computing time

TT23765
sergio-teruel and others added 17 commits July 11, 2023 15:57
Currently translated at 82.3% (14 of 17 strings)

Translation: credit-control-14.0/credit-control-14.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-sale_financial_risk/fr/
Currently translated at 11.7% (2 of 17 strings)

Translation: credit-control-14.0/credit-control-14.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-sale_financial_risk/nl/
`account.move` `post()` is deprecated since Odoo 14.0.
The import failure was not detected as error in CI, and restoring it,
reveals other problems in the tests.
Currently translated at 85.0% (17 of 20 strings)

Translation: credit-control-15.0/credit-control-15.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-15-0/credit-control-15-0-sale_financial_risk/fr/
Currently translated at 25.0% (5 of 20 strings)

Translation: credit-control-15.0/credit-control-15.0-sale_financial_risk
Translate-URL: https://translation.odoo-community.org/projects/credit-control-15-0/credit-control-15-0-sale_financial_risk/it/
Copy link

@ellbristow ellbristow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot migration sale_financial_risk
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 19, 2023
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-280-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 19, 2023
12 tasks
@OCA-git-bot OCA-git-bot merged commit 2be46f1 into OCA:16.0 Jul 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b454871. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.