Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] partner_risk_insurance: Migration to 16.0 #305

Merged
merged 26 commits into from
Nov 24, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Aug 16, 2023

Migration to 16.0

Changes done:

  • The compute is removed from the credit_limit field to avoid inconsistencies with the same field that adds account.
  • Specific inverse is added for the company_credit_limit + insurance_credit_limit fields.
  • The value of credit_limit is defined with _inverse_oca_oca_credit_limit() to maintain the functionality of this module and that of account.

Please @CarlosRoca13 and @stefan-tecnativa can you review it?

@Tecnativa TT44335

@victoralmau victoralmau force-pushed the 16.0-mig-partner_risk_insurance branch from 2484ffd to 541546b Compare August 16, 2023 12:54
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@pedrobaeza
Copy link
Member

/ocabot migration partner_risk_insurance

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 16, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 16, 2023
12 tasks
@pedrobaeza
Copy link
Member

Not sure about the feature of the credit limit introduced in this module, so calling @carlosdauden for his blessing.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rafaelbn
Copy link
Member

rafaelbn commented Oct 2, 2023

@carlosdauden @Shide a last review here? This is going to be migrated

@victoralmau
Copy link
Member Author

Changes done, can you check it again?

@rafaelbn rafaelbn requested a review from Shide October 18, 2023 22:53
@josep-tecnativa
Copy link

Please, add this changes according to the comment bc7a7e6#r130488985

@stefan-tecnativa
Copy link

@victoralmau I've forward ported some commits from this PR: #337 Can you check that everything is okay?
ping @carlosdauden

campos and others added 9 commits November 20, 2023 10:18
[11.0][MIG] partner_risk_insurance: Migration to v11.0

[11.0][IMP] partner_risk_insurance: Fix ES translation

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-11.0/credit-control-11.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-11-0/credit-control-11-0-partner_risk_insurance/

[UPD] README.rst

[UPD] Update partner_risk_insurance.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-11.0/credit-control-11.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-11-0/credit-control-11-0-partner_risk_insurance/
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-12.0/credit-control-12.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-12-0/credit-control-12-0-partner_risk_insurance/
Tardo and others added 17 commits November 20, 2023 10:23
pre-commit update

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-13.0/credit-control-13.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-13-0/credit-control-13-0-partner_risk_insurance/
[13.0][IMP] Add a view priority

partner_risk_insurance 13.0.1.1.0
…d insurance_credit_limit on partners

partner_risk_insurance 13.0.1.1.1
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-14.0/credit-control-14.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-partner_risk_insurance/
Currently translated at 100.0% (27 of 27 strings)

Translation: credit-control-14.0/credit-control-14.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-partner_risk_insurance/it/
[UPD] Update partner_risk_insurance.pot

[UPD] README.rst
Currently translated at 100.0% (27 of 27 strings)

Translation: credit-control-15.0/credit-control-15.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-15-0/credit-control-15-0-partner_risk_insurance/it/
…eter tracking

That parameter is added in mail module

partner_risk_insurance 15.0.1.0.2

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-15.0/credit-control-15.0-partner_risk_insurance
Translate-URL: https://translation.odoo-community.org/projects/credit-control-15-0/credit-control-15-0-partner_risk_insurance/
- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates
[UPD] Update partner_risk_insurance.pot

[BOT] post-merge updates
@victoralmau victoralmau force-pushed the 16.0-mig-partner_risk_insurance branch from f8d2c28 to 968984a Compare November 20, 2023 09:26
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-305-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 07ab433 into OCA:16.0 Nov 24, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7875915. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-partner_risk_insurance branch November 24, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.