Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] crm_lead_firstname: Migration to 11.0 #217

Merged
merged 4 commits into from
Aug 28, 2018

Conversation

EmailsGmails
Copy link

I've just signed my CLA, so it's pending.

@pedrobaeza
Copy link
Member

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

"summary": "Specify split names for contacts in leads",
"version": "11.0.1.0.0",
"category": "Customer Relationship Management",
"website": "http://www.antiun.com",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

website should be https://github.com/OCA/crm

@oca-clabot

This comment has been minimized.

@EmailsGmails EmailsGmails force-pushed the 11.0-mig-crm-lead-firstname branch 4 times, most recently from 8eb9d39 to 361efd3 Compare August 16, 2018 13:15
@pedrobaeza pedrobaeza added this to the 11.0 milestone Aug 16, 2018
@pedrobaeza
Copy link
Member

Please check Travis errors.

@EmailsGmails EmailsGmails force-pushed the 11.0-mig-crm-lead-firstname branch 3 times, most recently from 3d28907 to 15e55b7 Compare August 22, 2018 14:59
Copy link

@mlaitinen mlaitinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaitinen
Copy link

@MeetKD The commits and CI builds are OK now. Can you please re-review this?

@pedrobaeza pedrobaeza mentioned this pull request Aug 27, 2018
28 tasks
yajo and others added 4 commits August 27, 2018 09:47
This module adds the lastname field to leads and converts current contact name into contact firstname.

Allows to transfer that from and to res.partner objects.
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeetKD can you confirm your review?

@pedrobaeza pedrobaeza merged commit 37f2c85 into OCA:11.0 Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants