Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] crm_claim: Migration to v12 #246

Merged
merged 13 commits into from
Feb 20, 2019
Merged

[12.0][MIG] crm_claim: Migration to v12 #246

merged 13 commits into from
Feb 20, 2019

Conversation

cristinamartinrod
Copy link
Member

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 28, 2018
@pedrobaeza
Copy link
Member

Squash adjacent translation and POT commits

@MiquelRForgeFlow

This comment has been minimized.

Sign in to view
@pedrobaeza

This comment has been minimized.

Sign in to view
@sergio-teruel sergio-teruel force-pushed the 12.0-mig-crm_claim branch 3 times, most recently from 4ff63fa to e49b18e Compare November 29, 2018 17:31
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
Closed
20 tasks
anandkansagra
anandkansagra reviewed Dec 28, 2018
View reviewed changes
Copy link
Member

@anandkansagra anandkansagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis seems failed

@anandkansagra
Copy link
Member

Code migration is LGTM

@pedrobaeza
Copy link
Member

@cristinamartinrod please fix Travis

@pedrobaeza
Copy link
Member

@cristinamartinrod please include #259

@anajuaristi
Copy link

functional test OK for this PR
👍

@anajuaristi
Copy link

Could it be merged??? Thanks

oihane
oihane approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@oihane oihane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only missing what @pedrobaeza told to change

@pedrobaeza
Copy link
Member

The default type is already fixed, so I merge.

@pedrobaeza pedrobaeza merged commit 8658d3c into OCA:12.0 Feb 20, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-crm_claim branch February 20, 2019 23:37
@anajuaristi
Copy link

GRACIAS a todos!!! Y una más que ya tenemos en V12.
Sois la leche.
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandkansagra anandkansagra anandkansagra approved these changes

@DarioLodeiros DarioLodeiros DarioLodeiros approved these changes

@oihane oihane oihane approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.