Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] crm_phonecall #247

Merged
merged 14 commits into from
Dec 19, 2018
Merged

[12.0] [MIG] crm_phonecall #247

merged 14 commits into from
Dec 19, 2018

Conversation

anandkansagra
Copy link
Member

Issue Reference

cubells and others added 13 commits November 29, 2018 16:26
@cubells @anandkansagra
[MIG] crm_phone_call: Migrated to 10.0 (OCA#138)
bd94275 
* crm_phonecall module (OCA#131)

This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module.

Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history.

* [MIG] crm_phone_call: Migrated to 10.0

 - FIX: Correct some lint errors

* [MIG] crm_phone_call: Migrated to 10.0
@oca-transbot @anandkansagra
OCA Transbot updated translations from Transifex
200bd1f
@cubells @anandkansagra
[IMP] Add smartbutton to leads and opportunities
33421b3
@oca-transbot @anandkansagra
OCA Transbot updated translations from Transifex
58c590a
@yajo @anandkansagra
[IMP][crm_phonecall] Add utm.mixin fields
88e17cb
@jesusVMayor @anandkansagra
crm_phonecall: Fix action to redirect to the new phonecall when its c…
fd60c4b 
…reated from phonecall2phonecall wizard.
@oca-transbot @anandkansagra
OCA Transbot updated translations from Transifex
dff5139
@grindtildeath @anandkansagra
[FIX] crm_phonecall: C8108(method-compute) + E8103(sql-injection)
3e4550f
@oca-travis @anandkansagra
[UPD] Update crm_phonecall.pot
562131b
@chienandalu @anandkansagra
[MIG] crm_phonecall: Migration to 11.0
dbcfb17
@oca-travis @anandkansagra
[UPD] Update crm_phonecall.pot
c96dd6b
@OCA-git-bot @anandkansagra
[UPD] README.rst
a276e4b
@anandkansagra
crm_phonecall: fixes to skip duration computation on phonecalls witho…
4291cab 
…ut `date`
@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 30, 2018
@pedrobaeza
Copy link
Member

Please check CIs status

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 30, 2018
Closed
20 tasks
@anandkansagra anandkansagra force-pushed the 12.0-mig-crm_phonecall branch 2 times, most recently from 7250a0d to 2a4c111 Compare November 30, 2018 10:19
@anandkansagra
Copy link
Member Author

Please check CIs status

CIs seems green now.

@pedrobaeza
Copy link
Member

Thanks. Little warnings on runbot:

2018-11-30 10:39:43,991 157 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (phonecall_count, phonecall_ids) of res.partner() have the same label: Phonecalls.
2018-11-30 10:39:44,025 157 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (phonecall_count, phonecall_ids) of crm.lead() have the same label: Phonecalls.
2018-11-30 10:39:44,079 157 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (phonecall_count, phonecall_ids) of res.users() have the same label: Phonecalls.

@anandkansagra
Copy link
Member Author

Thanks. Little warnings on runbot:

2018-11-30 10:39:43,991 157 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (phonecall_count, phonecall_ids) of res.partner() have the same label: Phonecalls.
2018-11-30 10:39:44,025 157 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (phonecall_count, phonecall_ids) of crm.lead() have the same label: Phonecalls.
2018-11-30 10:39:44,079 157 WARNING openerp_test odoo.addons.base.models.ir_model: Two fields (phonecall_count, phonecall_ids) of res.users() have the same label: Phonecalls.

Done

@anandkansagra anandkansagra mentioned this pull request Dec 1, 2018
Closed
rven
rven approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@rven rven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the functionality and it works like expected.

pedrobaeza
pedrobaeza requested changes Dec 18, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little things, but good work in general!

As you are touching the PR, can you squash 2 translation commits that are from the same person (2 previous ones before the migration commits) so we reduce the final size?

crm_phonecall/models/crm_phonecall.py Outdated Show resolved Hide resolved
crm_phonecall/views/crm_phonecall_view.xml Outdated Show resolved Hide resolved
@anandkansagra
Copy link
Member Author

@pedrobaeza ,I have made changes. Could you please look it out?

pedrobaeza
pedrobaeza requested changes Dec 19, 2018
View reviewed changes
crm_phonecall/models/crm_phonecall.py Outdated Show resolved Hide resolved
crm_phonecall/models/crm_phonecall.py Outdated Show resolved Hide resolved
crm_phonecall/models/crm_phonecall.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 952a8b2 into OCA:12.0 Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rven rven rven approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.