Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9.0 move crm department #77

Closed
wants to merge 33 commits into from
Closed

9.0 move crm department #77

wants to merge 33 commits into from

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Feb 19, 2016

Incorporates the discussion in PR OCA/department#49

jgrandguillaume and others added 28 commits August 12, 2011 14:53
@jgrandguillaume
[ADD] Commit of the modules used by C2C to move in our new public branch
513e26d 
(lp:c2c-addons/6.1  rev 2)
@yvaucher
[IMP] Unlink sales team and departments in form view of Opportunities
dd5d54c 
(lp:c2c-addons/6.1  rev 5)
@gurneyalex
[MERGE] from bzr+ssh://bazaar.launchpad.net/+branch/c2c-addons/trunk/
a1eae59 
(lp:c2c-addons/6.1  rev 28.2.1)
@guewen
[MIGR] set installable to False on all the modules, the flag has to b…
c66aff7 
…e reactivated when the modules are migrated
@yvaucher
[MIG] portage of crm_department by OpenERP
90b8fdd
@yvaucher
[IMP] crm_department - use orm.Model instead of alias osv.osv
4c8d411
@yvaucher
[IMP] crm_department - update license
c2ed452
@yvaucher
[IMP] crm_department - retab xml file
7686b52
@yvaucher
[IMP] crm_department - add a space
4f1f5c5
@JordiBForgeFlow
Corrects bug #1296055
5af08b1
@JordiBForgeFlow
If no department was found in the sales team the department assigned …
8031312 
…to the employee is determined.
@JordiBForgeFlow
Code cleanup
9d52c8f
@JordiBForgeFlow
More code style changes.
a23fd1e
@JordiBForgeFlow
Replace self.pool.get() references by self.pool[]
527418f 
Removed department determination from sales team. Determination only occurs from employee.
@JordiBForgeFlow @yvaucher
[FIX] lp:1296055 - When the user_id is changed in crm.lead the applic…
ce3c500 
…ation determines the section (sales team) and based on that, the department that the sales team is assigned to. If the sales team does not have an associated department the department of the employee of the salesperson is used.
@dreispt
Set modules as not installable
dfea683
@dreispt
Move modules to unported dir
a8efb45
starting port of crm_department
36b0dbc
view adjustments + flag as installable
dc59cfc 
forgot to uncomment form view
pep8, add a README.rst
5e11b6c 
move description from __openerp__.py to README.rst
(manually) filled contributors section
302d37d
fix headline
8e01567
removed stub sections in README.rst
eb4cb9f
corrected credits (not ready for automation)
2d8807e
@sbidoul
[UPD] prefix versions with 8.0
6a8e9ea
@dreispt
Move crm_department from OCA/department(8.0)
e954080
@dreispt
Fix OCA lint
9902b93
@dreispt
Port to 9.0 and new API
69017a1
elicoidal
elicoidal reviewed Feb 20, 2016
View reviewed changes
crm_department/README.rst Outdated
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:alt: License: AGPL-3

CRM with Department Categorization
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line before

@dreispt
Copy link
Member Author

dreispt commented Oct 17, 2016

Sorry, completely forgot about this.
Tried to fix it.

pedrobaeza
pedrobaeza approved these changes Oct 17, 2016
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 non blocking points

crm_department/i18n/crm_department.pot Outdated
@@ -0,0 +1,24 @@
# Translation of OpenERP Server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove POT file

crm_department/README.rst Outdated
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3

CRM with Department Categorization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line above also

@dreispt
Copy link
Member Author

dreispt commented Oct 18, 2016

@danimaribeiro Can you recheck, please?

@rafaelbn
Copy link
Member

Hi @dreispt could you please review runbot, I will test it in order to merge. Thanks!

@oca-clabot
Copy link

Hey @dreispt, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Charbel Jacquin (no github login found)

Appreciation of efforts,
OCA CLAbot

@rafaelbn rafaelbn closed this Jun 8, 2017
@rafaelbn rafaelbn reopened this Jun 8, 2017
@dreispt
Copy link
Member Author

dreispt commented Jun 8, 2017

I forced a rebuild.

@MiquelRForgeFlow
Copy link
Contributor

And the rebuild is lagged and stalled

@dreispt
Copy link
Member Author

dreispt commented Aug 10, 2017

Runbot rebuild doesn' work. I have green CI.
Can we move on?

claudiagn
claudiagn approved these changes Mar 30, 2021
View reviewed changes
Copy link

@claudiagn claudiagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 24, 2021
@dreispt
Copy link
Member Author

dreispt commented Oct 31, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 9.0-ocabot-merge-pr-77-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 31, 2021
@OCA-git-bot
Merge PR #77 into 9.0
0885dda 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 9.0-ocabot-merge-pr-77-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022
@github-actions github-actions bot closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@claudiagn claudiagn claudiagn approved these changes

Assignees
No one assigned
Labels
approved needs fixing needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.