-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][crm_phonecall_summary_predefined] Restricted list of possible summaries for phone calls #78
Conversation
I cannot test it, runbot fails. After trying to rebuild it is killed in testing stage |
I don't know what could it be. Maybe @gurneyalex can help? |
Thansk. Tested, you miss field categ_id in crm.phonecall list view. Please add it, it another select field related to this module and functionality. Thanks |
Yes @rafaelbn, thanks. It will land in a new addon ASAP. |
Please review runbot errors
|
@rafaelbn Thanks, a very interesting bug to fix. |
Travis fixed. Runbot's failure fixed in OCA/partner-contact#250 |
I prefer the module name crm_phonecall_predefined_summary |
Configuration | ||
============= | ||
|
||
To configure this module, you need to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To configure the possible summary options, go...
Don't create a .empty file in i18n: put the es.po or don't put anything. |
<field name="inherit_id" ref="crm.crm_case_inbound_phone_tree_view"/> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//field[@name='name']" position="attributes"> | ||
<attribute name="name">summary_id</attribute> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't replace, but hide the other field. This is a very bad practice, because other modules can inherit the view referencing this field.
Fixed all. Renamed to |
…ummaries for phone calls This module fills the gap of phone marketing companies where phone call summaries can only belong to a limited amount of possibilities.
Name for me is OK: crm_phonecall_summary_predefined. |
Tested functionally and 👍 thanks! |
👍 |
Tested.. 👍 |
[8.0][crm_phonecall_summary_predefined] Restricted list of possible summaries for phone calls
Hi @yajo we miss here in this module to add summary in crm.phonecall.report. we must make an IMP |
This module fills the gap of phone marketing companies where phone call summaries can only belong to a limited amount of possibilities.
@rafaelbn