[8.0][crm_phonecall_summary_predefined] Restricted list of possible summaries for phone calls

[yajo]

This module fills the gap of phone marketing companies where phone call summaries can only belong to a limited amount of possibilities.

@rafaelbn

[rafaelbn]

I cannot test it, runbot fails. After trying to rebuild it is killed in testing stage

[yajo]

I don't know what could it be. Maybe @gurneyalex can help?

[rafaelbn]

Thansk. Tested, you miss field categ_id in crm.phonecall list view. Please add it, it another select field related to this module and functionality. Thanks

[yajo]

Yes @rafaelbn, thanks. It will land in a new addon ASAP.

[rafaelbn]

Please review runbot errors

2016-02-24 15:44:57     ERROR   server  openerp.sql_db:241 execute

bad query: ALTER TABLE "crm_phonecall" ALTER COLUMN "summary_id" SET NOT NULL
Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142507-78-6d97f9/openerp/sql_db.py", line 234, in execute
    res = self._obj.execute(query, params)
IntegrityError: column "summary_id" contains null values

2016-02-24 15:44:57     WARNING     server  openerp.models:2674 _auto_init

WARNING: unable to set column summary_id of table crm_phonecall not null !
Try to re-run: openerp-server --update=module
If it doesn't work, update records and execute manually:
ALTER TABLE crm_phonecall ALTER COLUMN summary_id SET NOT NULL
Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142507-78-6d97f9/openerp/models.py", line 2666, in _auto_init
    cr.execute('ALTER TABLE "%s" ALTER COLUMN "%s" SET NOT NULL' % (self._table, k))
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142507-78-6d97f9/openerp/sql_db.py", line 158, in wrapper
    return f(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142507-78-6d97f9/openerp/sql_db.py", line 234, in execute
    res = self._obj.execute(query, params)
IntegrityError: column "summary_id" contains null values

[yajo]

@rafaelbn Thanks, a very interesting bug to fix.

[yajo]

Travis fixed. Runbot's failure fixed in OCA/partner-contact#250

[pedrobaeza]

I prefer the module name crm_phonecall_predefined_summary

[pedrobaeza]

To configure the possible summary options, go...

[pedrobaeza]

Don't create a .empty file in i18n: put the es.po or don't put anything.

[pedrobaeza]

Don't replace, but hide the other field. This is a very bad practice, because other modules can inherit the view referencing this field.

[yajo]

Fixed all. Renamed to crm_phonecall_summary_predefined, seems better IMHO. Is it ok?

[rafaelbn]

Name for me is OK: crm_phonecall_summary_predefined.

[rafaelbn]

Tested functionally and 👍 thanks!

[pedrobaeza]

👍

[sergio-teruel]

Tested.. 👍

[rafaelbn]

Hi @yajo we miss here in this module to add summary in crm.phonecall.report. we must make an IMP