Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Banco Central de Venezuela Currency Provider #188

Closed
wants to merge 1 commit into from
Closed

[ADD] Banco Central de Venezuela Currency Provider #188

wants to merge 1 commit into from

Conversation

lapinzon
Copy link

@lapinzon lapinzon commented Nov 7, 2023

This simple module extracts rates from the Central Bank of Venezuela website for EUR, CNY, TRY, RUB and USD currencies

@alexey-pelykh
Copy link
Contributor

@lapinzon thanks for your PR! This module should be in https://github.com/OCA/l10n-venezuela

@lapinzon
Copy link
Author

lapinzon commented Nov 8, 2023

Hi,

This localization for Venezuela has been abandoned for 8 years and is no longer valid, but for those who are adopting Odoo, adding this currency rate provider may be useful.

Please reconsider including this module in the currency rate providers project.

I really want to contribute, but I am just joining OCA and its standards.

Best regards

@alexey-pelykh
Copy link
Contributor

Regardless, the localization-related modules are supposed to be in the l10n repos.

@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 8, 2023

@lapinzon you can include your module in https://github.com/OCA/l10n-venezuela/tree/16.0 without needing the rest of the localization modules to be migrated. It's just where to host it. In there, you are able also to talk in Spanish to ease your development and review flow.

@lapinzon
Copy link
Author

lapinzon commented Nov 8, 2023

@lapinzon you can include your module in https://github.com/OCA/l10n-venezuela/tree/16.0 without needing the rest of the localization modules to be migrated. It's just where to host it. In there, you are able also to talk in Spanish to ease your development and review flow.

Thank you Pedro for clarifying. I hope to learn the flow and be able to actively collaborate. I will go there.
También aspiro mejorar mi pobre inglés.

@pedrobaeza
Copy link
Member

Go with it! First time it requires a bit of work to adapt to the flows, but you will get use soon.

@alexey-pelykh
Copy link
Contributor

@pedrobaeza you make me looking like a bad cop vs good cop :) how the tables turned!

@pedrobaeza
Copy link
Member

Hahaha, nothing far from reality. I will always be the bad guy putting "Requested changes" reviews 😝

It's just that this time I had the minutes to explain a bit the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants