[13.0][FIX] ddmrp: buffer profiles must be no-update #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordiBForgeFlow
approved these changes
Jun 8, 2021
jgrandguillaume
approved these changes
Jun 9, 2021
Any change in the profiles is overridden when updating the module. Also this trigger the recomputation of the buffer zones, as they depend on buffer profile changes, this is unwanted. CSV data does not support no-update tag so the date is converted to xml.
LoisRForgeFlow
force-pushed
the
13.0-fix-ddmrp-no-update-data
branch
from
d4d9945
to
ce41ae9
Compare
Closed
|
Travis error is unrelated to this PR, see #145. |
|
Travis error is now solved. /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 6c57722. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any change in the profiles is overridden when updating the module.
Also this trigger the recomputation of the buffer zones, as
they depend on buffer profile changes, this is unwanted.
CSV data does not support no-update tag so the date is converted to xml.
cc @jgrandguillaume
@ForgeFlow
NOTE: to be merged with nobump.