Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] ddmrp_packaging #218

Merged
merged 31 commits into from
Mar 24, 2022
Merged

Conversation

ChrisOForgeFlow
Copy link
Contributor

Standard Migration
@ForgeFlow

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration ddmrp_packaging

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 17, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 17, 2022
13 tasks
@LoisRForgeFlow
Copy link
Contributor

Looks great with the new tests 👍 Could you squash the last 2 commits?

LoisRForgeFlow and others added 26 commits March 18, 2022 08:35
when navigating to a package from the buffer. For instance, when
the `delivery` module the delivery view gets precedence.
It has been proven to be a problem more than an aid.
As long as the qty_multiple is updated correctly the recommended
procurement will respect it. MOQ field should be reserved to
contractual constraints agreed with the vendor.
When the contained quantity of a packaging is updated, it should
update the product multiple quantity in all the buffers where it
is used.
fields instead of onchange.

This ensures consistent behavior on backend changes and changes
done using UI. Being more specific, without this change there was
as conflict with the module `ddmrp_product_replace`, when you
replace a product, the product of the buffer is written but the
packaging is not cleared out like it happens when you do it
using UI.

This is more in line with the most recent odoo guidelines to
reduce the use of onchange methods and also good to avoid the
need for a glue module.
Set a value on every path in a compute method.
On the wizard to make a procurement from a stock.buffer.
This change allows to select a packaging and a quantity of that
specific packaging, to automatically fill the quantity to procure.
@ChrisOForgeFlow
Copy link
Contributor Author

Looks great with the new tests +1 Could you squash the last 2 commits?

Sure!, already done

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-218-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 78e2c8d into OCA:15.0 Mar 24, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 06911f0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants