[14.0][FIX] ddmrp: use archived locations in the ADU computation #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LoisRForgeFlow, @JordiBForgeFlow, |
sebalix
force-pushed
the
14-ddmrp-handle-archived-locations
branch
from
ed7f695
to
10b1a85
Compare
simahawk
approved these changes
Apr 21, 2023
TDu
approved these changes
Apr 21, 2023
sebalix
force-pushed
the
14-ddmrp-handle-archived-locations
branch
from
10b1a85
to
387a0cb
Compare
|
Tests are failing, otherwise the change looks fine. |
sebalix
force-pushed
the
14-ddmrp-handle-archived-locations
branch
from
387a0cb
to
6426a1d
Compare
|
This PR has the |
sebalix
force-pushed
the
14-ddmrp-handle-archived-locations
branch
from
6426a1d
to
d63ee0c
Compare
sebalix
force-pushed
the
14-ddmrp-handle-archived-locations
branch
from
d63ee0c
to
dfcb9b4
Compare
|
@LoisRForgeFlow sorry for being late, I rebased the PR and fix the issue to make tests working again. |
LoisRForgeFlow
approved these changes
Jul 5, 2023
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 42cbdd9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the ADU from X past days, archived locations are not taken into account, resulting in a wrong qty.
Same issue for the consumption view.
Ref. 4064