[13.0][FIX] dms: Show only real subdirectories in view and when we use searchpanel directory filter #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chpanel directory filter
yajo
reviewed
Jul 8, 2021
Comment on lines
+685
to
+712
|
|
||
| @api.model | ||
| def search_read(self, domain=None, fields=None, offset=0, limit=None, order=None): | ||
| """ | ||
| It's necessary to prevent parent_id=False when searchpanel filter by directory | ||
| and prevent auto-aplly ('parent_id','child_of',xx) domain because it is not | ||
| expected for us (if we filter by Documents directory we expected view only | ||
| subdirectories and not Documents directory), similar to computer filestore. | ||
| """ | ||
| if self.env.context.get("override_search_read") and len(domain) > 0: | ||
| domain.reverse() | ||
| domain2 = [] | ||
| parent_id_override = False | ||
| for item in domain: | ||
| if item[0] == "parent_id" and item[1] == "child_of": | ||
| domain2.append([item[0], "=", item[2]]) | ||
| parent_id_override = True | ||
| elif not parent_id_override or ( | ||
| parent_id_override | ||
| and not bool( | ||
| item[0] == "parent_id" and item[1] == "=" and not item[2] | ||
| ) | ||
| ): | ||
| domain2.append(item) | ||
| domain = domain2 | ||
| return super().search_read( | ||
| domain=domain, fields=fields, offset=offset, limit=limit, order=order | ||
| ) |
There was a problem hiding this comment.
Why do you need to override this method? Doesn't [('parent_id', '=', False)] return the top level directories already? Can't you just use that domain in the action?
There was a problem hiding this comment.
But shouldn't folders be shown according current subdirectory level? Thus it should be something like: parent_id = <current_subdirectory>, being False or other.
|
I close this because this idea is included in #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show only real subdirectories in view and when we use searchpanel directory filter.
Related to #40
Please @pedrobaeza and @yajo can you review it?
It's necessary to apply 14.0 too.
@Tecnativa TT30826