[15.0] [MIG] dms

[JasminSForgeFlow]

Standard Migration

@ForgeFlow

Depends on:

• [15.0] [MIG] web_drop_target web#2139
• [15.0] [MIG] mail_preview_base social#842

[JasminSForgeFlow]

Hi @sbidoul,

pre-commit command is failing here because of one CSV file in demo data.

This CSV file is used in the demo data file dms/dms/demo/file.xml.

Gives below error

Can you please take a look and help us to solve it?

Thanks

[pedrobaeza]

Please fix CIs and cherry-pick this recent commit: acfe367

[JasminSForgeFlow]

Please fix CIs and cherry-pick this recent commit: acfe367

Hi @pedrobaeza,

cheery-pick is done.

CIs failed because the module depends on
OCA/web#2139
OCA/social#842

and there is one issue coming with pre-commit for one CSV demo data file. So for that require to do changes in pre-commit.

Thanks

[pedrobaeza]

OK, we have to wait then for the rest to be merged.

[victoralmau]

Please cherry pick this last change: #161

[victoralmau]

First of all thanks for the contribution.
Some comments:

• I think it is necessary to squash the administrative commits.
• It will be necessary to add the change [14.0][FIX] dms: Replace the content field with size in the form view of the directory #161 from v14 (this change and the previous one will need to be placed in order, that is, before the commit "[IMP] dms: black, isort , prettier" to respect the change history).
• I see that in the changes applied in the commit "Migration to 15.0" many string= are removed from many fields and views, I think this is not necessary and it generates a very large diff that makes the revision difficult.

[JasminSForgeFlow]

First of all thanks for the contribution. Some comments:

• I think it is necessary to squash the administrative commits.
• It will be necessary to add the change [14.0][FIX] dms: Replace the content field with size in the form view of the directory #161 from v14 (this change and the previous one will need to be placed in order, that is, before the commit "[IMP] dms: black, isort , prettier" to respect the change history).
• I see that in the changes applied in the commit "Migration to 15.0" many string= are removed from many fields and views, I think this is not necessary and it generates a very large diff that makes the revision difficult.

Hi @victoralmau ,

Changes of #161 have been pulled and squash administrative commit. Please check it.

Regarding string= it's required in v15 to remove otherwise pre-commit test will be failed.

Thanks

[victoralmau]

Good job, thanks for the changes, the code review is OK.
When the dependencies of this addon are merged I will test it in runbot.

[victoralmau]

Please cherry pick this last change: #166 (before v15 migration commits)

[etobella]

@JasminSForgeFlow Can you check @victoralmau comments?

[JasminSForgeFlow]

@JasminSForgeFlow Can you check @victoralmau comments?

Hi @etobella,

I have cherry-pick #166 and also rebased with 15,0

Thanks

[etobella]

@victoralmau It seems ready for merge. May I kindly ask for a review ??

[etobella]

@victoralmau It seems ready for merge. May I kindly ask for a review ??

[victoralmau]

Thanks a lot, very good job!!

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-159-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 6d635ab. Thanks a lot for contributing to OCA. ❤️

[pedrobaeza]

/ocabot migration dms