Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][FIX] dms: Misc changes. #226

Merged
merged 3 commits into from
Feb 9, 2023
Merged

[13.0][FIX] dms: Misc changes. #226

merged 3 commits into from
Feb 9, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 7, 2023 •
edited
Loading

Use case:

  • Create a "Documents" directory with access to Admin user.
  • Create a "Code" directory with read-only access to the Test (new user) user.
  • Create a file in "Code" folder.

Remove parent_id defined if you do not have access to it search panel directory.
Before:
antes-1

After:
despues-1

Get the "parent" directories (those of the top level to which you have access) in the portal view.
Before:
antes-2

After:
despues-2

Limit breadcrumb from portal to directories you have access to.

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT41585

@pedrobaeza pedrobaeza added this to the 13.0 milestone Feb 7, 2023
pedrobaeza
pedrobaeza reviewed Feb 7, 2023
View reviewed changes
dms/models/directory.py Outdated Show resolved Hide resolved
pedrobaeza
pedrobaeza reviewed Feb 8, 2023
View reviewed changes
dms/models/directory.py Outdated Show resolved Hide resolved
dms/models/directory.py Outdated Show resolved Hide resolved
@pedrobaeza
Copy link
Member

Patching this:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-226-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a1b564 into OCA:13.0 Feb 9, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 52aeeb0. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Feb 10, 2023
Merged
@pedrobaeza pedrobaeza deleted the 13.0-fix-dms-TT41585 branch August 8, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu