Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] dms_attachment_link: New module #227

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

victoralmau
Copy link
Member

New module

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT41512

@pedrobaeza pedrobaeza added this to the 13.0 milestone Feb 8, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you explore the possibilities of adding the side panel with the folder hierarchy?

Please put this icon in the module:
icon
icon

dms_attachment_link/README.rst Outdated Show resolved Hide resolved
dms_attachment_link/README.rst Outdated Show resolved Hide resolved
dms_attachment_link/README.rst Outdated Show resolved Hide resolved
dms_attachment_link/README.rst Outdated Show resolved Hide resolved
dms_attachment_link/README.rst Outdated Show resolved Hide resolved
dms_attachment_link/README.rst Outdated Show resolved Hide resolved
dms_attachment_link/models/ir_attachment.py Show resolved Hide resolved
@victoralmau
Copy link
Member Author

Changes done (thanks for the icons).

I will explore the possibility of adding the side panel and will comment on it soon.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For the current code

@pedrobaeza
Copy link
Member

Let's merge it with current code, and further improvements if possible to add the side panel, can come later:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-227-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ac3a1e4 into OCA:13.0 Feb 9, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e6a4789. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-add-dms_attachment_link branch August 8, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants