[14.0][FIX] dms: try/except for thumbnail generation of dms.file #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleuffre
force-pushed
the
14.0-dms-image-fix
branch
from
db17b07
to
d00e012
Compare
The method _compute_image_1920 of dms_file checks if the file is of
mimetype image and tries to use it as a thumbnail.
However, there are several types of image files that Odoo/PIL
cannot work with, leading to the following error:
```
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/tools/image.py", line 404, in base64_to_image
return Image.open(io.BytesIO(base64.b64decode(base64_source)))
File "/usr/local/lib/python3.6/site-packages/PIL/Image.py", line 2687, in open
% (filename if filename else fp))
OSError: cannot identify image file <_io.BytesIO object at 0x7f0a6ecb1780>
```
and also further down
```
odoo.exceptions.UserError: ('This file could not be decoded as an image file. Please try with a different file.', '')
```
Examples of such files are CAD files (mimetype: image/vnd.dwg)
For a list of all mimetypes starting with "image/" see:
https://www.iana.org/assignments/media-types/media-types.xhtml#image
aleuffre
force-pushed
the
14.0-dms-image-fix
branch
from
d00e012
to
825c17a
Compare
pedrobaeza
approved these changes
Apr 20, 2023
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0a7bdec. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW of #236
Cherry pick of d8fde2e