Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][FIX] dms: Explicitly exclude the pdf type in the image_1920 field of the files. #248

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[13.0][FIX] dms: Explicitly exclude the pdf type in the image_1920 field of the files. #248

merged 1 commit into from
Jun 15, 2023

Conversation

victoralmau
Copy link
Member

Explicitly exclude the pdf type in the image_1920 field of the files.

Please @pedrobaeza can you review it?

@Tecnativa TT43563

@pedrobaeza
Copy link
Member

Please check pre-commit

@pedrobaeza pedrobaeza requested a review from aleuffre June 15, 2023 15:04
aleuffre
aleuffre approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the amount of mimetypes to include/exclude grows, I'd create some constants or something to better keep track of them, but for now LGTM

etobella
etobella approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-248-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 42f3154 into OCA:13.0 Jun 15, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1f75704. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-fix-dms-TT43563 branch June 15, 2023 19:58
@victoralmau victoralmau mentioned this pull request Jun 19, 2023
Closed
@victoralmau victoralmau mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@etobella etobella etobella approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victoralmau @pedrobaeza @OCA-git-bot @etobella @aleuffre