Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] dms_storage: Migration to 17.0 #362

Merged
merged 8 commits into from
Sep 6, 2024
Merged

[17.0][MIG] dms_storage: Migration to 17.0 #362

merged 8 commits into from
Sep 6, 2024

Conversation

BernatObrador
Copy link
Contributor

@BernatObrador BernatObrador commented Aug 27, 2024 •
edited
Loading

Module migrated to version 17.0

cc https://github.com/APSL 159859

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

peluko00
peluko00 suggested changes Aug 27, 2024
View reviewed changes
dms_storage/models/dms_file.py Outdated Show resolved Hide resolved
peluko00
peluko00 approved these changes Aug 27, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

ppyczko
ppyczko approved these changes Aug 29, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BernatObrador
Copy link
Contributor Author

@pedrobaeza Is this ready to merge?

@pedrobaeza
Copy link
Member

/ocabot migration dms_storage

@etobella please confirm

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 6, 2024
etobella
etobella approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-362-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 6, 2024
@OCA-git-bot
Merge PR #362 into 17.0
0cfdf2b 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-362-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-362-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-362-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 27c5a08 into OCA:17.0 Sep 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7f1b94e. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot mentioned this pull request Sep 6, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko approved these changes

@peluko00 peluko00 peluko00 approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@BernatObrador @OCA-git-bot @pedrobaeza @etobella @peluko00 @ppyczko @len-foss @mymage