Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] dms: Migration to 14.0 #66

Merged
merged 59 commits into from
May 17, 2021
Merged

[14.0][MIG] dms: Migration to 14.0 #66

merged 59 commits into from
May 17, 2021

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Mar 24, 2021 •
edited
Loading

Migration to 14.0 (in progress)

Locker by:

Ping @pedrobaeza and @etobella

@Tecnativa TT28893

@victoralmau victoralmau force-pushed the 14.0-mig-dms branch 2 times, most recently from cadcf1c to b544693 Compare March 24, 2021 13:12
@victoralmau victoralmau mentioned this pull request Mar 24, 2021
Merged
@victoralmau victoralmau force-pushed the 14.0-mig-dms branch 6 times, most recently from 0ce4b2c to 9a81892 Compare March 30, 2021 15:03
@victoralmau victoralmau mentioned this pull request Mar 30, 2021
Closed
@victoralmau
Copy link
Member Author

It's ready to review now.

@pedrobaeza
Copy link
Member

Travis is red. Maybe you can add the temporary branch for web_drop_target.

@victoralmau victoralmau force-pushed the 14.0-mig-dms branch 4 times, most recently from 31827f7 to 92dca3f Compare March 31, 2021 15:39
@pedrobaeza pedrobaeza added this to the 14.0 milestone Apr 1, 2021
@pedrobaeza pedrobaeza force-pushed the 14.0-mig-dms branch 2 times, most recently from 315acd6 to 08d47bd Compare April 1, 2021 06:48
@pedrobaeza
Copy link
Member

ping @sebastienbeau

kevinkhao
kevinkhao suggested changes Apr 7, 2021
View reviewed changes
Copy link

@kevinkhao kevinkhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@kevinkhao
Copy link

Drag and drop functionality doesn't detect selected directory

Peek 2021-04-07 17-01

@kevinkhao
Copy link

kevinkhao commented Apr 7, 2021 •
edited
Loading

Peek 2021-04-07 17-06
Drag and drop does work correctly if we come from directory kanban view-> click on file. However, the same problem occurs: selecting another directory has no effect (if you select another directory, try to drag and drop, only the previous directory is considered, i.e the one you clicked on from directory kanban view)

@kevinkhao
Copy link

Peek 2021-04-07 17-39
Filter by tag works on file_list view type. If you ever switch to file_kanban view type, the filter by tag functionality breaks until you refresh the page.

@kevinkhao
Copy link

kevinkhao commented Apr 7, 2021 •
edited
Loading

nitpicking
In kanban directory view, on individual kanban items, there is a button to open the files of this directory and subdirectories. The number of files on the tooltip doesn't match number of files displayed when clicking on the same button
Peek 2021-04-07 17-45

Shide and others added 7 commits May 17, 2021 08:16
@Shide @victoralmau
[12.0] [FIX] dms: Check default_directory_id context key
30fc6b5 
When creating an attachment, check `default_directory_id` too because this key comes from kanban js view and it's like `active_id` when creating files from drag and drop (drop target).

This change will allow to view the new file on the associated record if the folder has `res_model` and `res_id` (the parent folder is an attachment storage)

Fixes OCA#72
@victoralmau
[FIX] dms: Prevent parent_id error in directories in some UI cases [F…
a789a28 
…IX] dms: Change allowed_model_ids field in directory to related [FIX] dms: Change res_model + res_id fields in files to related
@victoralmau
[IMP] dms: Inherit permissions from related records
83f5625
@victoralmau
Translated using Weblate (Spanish)
61fc4b3 
Currently translated at 99.6% (323 of 324 strings)

Translation: dms-13.0/dms-13.0-dms
Translate-URL: https://translation.odoo-community.org/projects/dms-13-0/dms-13-0-dms/es/
@victoralmau
[DCK] Copier update to v1.1.3
6ee54a3
@victoralmau
[IMP] dms: black, isort, prettier
6c7438d
@victoralmau
[IMP] dms: black, isort, prettier
3a703a4
@victoralmau victoralmau force-pushed the 14.0-mig-dms branch 2 times, most recently from e775e32 to 40e9924 Compare May 17, 2021 06:20
@victoralmau
Copy link
Member Author

I have solved some conflicts, it's ready to review and merge right?

etobella
etobella reviewed May 17, 2021
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This button fails

@etobella
Copy link
Member

Code Review looks fine, just a small bug was found

@victoralmau
Copy link
Member Author

image
This button fails

Thanks, changes done.

@pedrobaeza
Copy link
Member

Let's merge it and more issues (if any) can be handled in later PRs:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-66-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 277ffd9 into OCA:14.0 May 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 66d1bbf. Thanks a lot for contributing to OCA. ❤️

@frankofno
Copy link

not sure where i could get the info to my question - is dms already compatible with odoo 14 community version?

@pedrobaeza pedrobaeza deleted the 14.0-mig-dms branch June 29, 2021 17:54
@pedrobaeza
Copy link
Member

Yes, this pull request is merged.

@frankofno
Copy link

Yes, this pull request is merged.

just tried to install it. I see the icon and the module seems to be installed. Allthough after creating a file store (database) i get some errors showing up. I can not use it, or maybe not sure how to install it the correct way.

how i installed it:
uploading the content of the dms folder to the odoo/odoo/addon/dms folder

chown -R odoo:odoo for addon/dms

-rw-rw-r-- 1 odoo odoo 5989 Jun 29 06:52 README.rst
-rw-rw-r-- 1 odoo odoo 47 Jun 29 06:52 init.py
-rw-rw-r-- 1 odoo odoo 1397 Jun 29 06:52 manifest.py
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 actions
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 controllers
drwxrwxr-x 3 odoo odoo 4096 Jun 29 06:52 demo
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 i18n
drwxrwxr-x 4 odoo odoo 4096 Jun 29 06:52 migrations
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 models
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 readme
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 security
drwxrwxr-x 5 odoo odoo 4096 Jun 29 06:52 static
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 template
drwxrwxr-x 3 odoo odoo 4096 Jun 29 06:52 tests
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 tools
drwxrwxr-x 2 odoo odoo 4096 Jun 29 06:52 views

in odoo -> apps and clicked on install

what am I missing, so I can get that version up and running?

@pedrobaeza
Copy link
Member

Sorry, this is out of scope of this place. Maybe you haven't put permissions, or something else with your deployment. Ask on forums or mailing lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkhao kevinkhao kevinkhao requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.