-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG] dms: Migration to 14.0 #66
Conversation
cadcf1c
to
b544693
Compare
0ce4b2c
to
9a81892
Compare
9a81892
to
e07abda
Compare
It's ready to review now. |
Travis is red. Maybe you can add the temporary branch for |
31827f7
to
92dca3f
Compare
315acd6
to
08d47bd
Compare
ping @sebastienbeau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
bac981c
to
6afccf1
Compare
6afccf1
to
915bc39
Compare
When creating an attachment, check `default_directory_id` too because this key comes from kanban js view and it's like `active_id` when creating files from drag and drop (drop target). This change will allow to view the new file on the associated record if the folder has `res_model` and `res_id` (the parent folder is an attachment storage) Fixes OCA#72
…IX] dms: Change allowed_model_ids field in directory to related [FIX] dms: Change res_model + res_id fields in files to related
Currently translated at 99.6% (323 of 324 strings) Translation: dms-13.0/dms-13.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-13-0/dms-13-0-dms/es/
e775e32
to
40e9924
Compare
I have solved some conflicts, it's ready to review and merge right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review looks fine, just a small bug was found |
Let's merge it and more issues (if any) can be handled in later PRs: /ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 66d1bbf. Thanks a lot for contributing to OCA. ❤️ |
not sure where i could get the info to my question - is dms already compatible with odoo 14 community version? |
Yes, this pull request is merged. |
just tried to install it. I see the icon and the module seems to be installed. Allthough after creating a file store (database) i get some errors showing up. I can not use it, or maybe not sure how to install it the correct way. how i installed it: chown -R odoo:odoo for addon/dms -rw-rw-r-- 1 odoo odoo 5989 Jun 29 06:52 README.rst in odoo -> apps and clicked on install what am I missing, so I can get that version up and running? |
Sorry, this is out of scope of this place. Maybe you haven't put permissions, or something else with your deployment. Ask on forums or mailing lists. |
Migration to 14.0 (in progress)
Locker by:
mail_preview_base
[14.0][MIG] mail_preview_base: Migration to 14.0 social#692web_drop_target
[14.0][MIG] web_drop_target: Migration to 14.0 web#1892Ping @pedrobaeza and @etobella
@Tecnativa TT28893