[14.0][FIX] dms: Remove _get_share_url() function because is not necessary to override nothing

[victoralmau]

Remove _get_share_url() function because is not necessary to override nothing (default work fine according to share wizard and auto-add access_token in link).

It's need to apply in 13.0 too.

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT29820

[pedrobaeza]

One question: shouldn't be the token then populated only if the new argument is true?

[victoralmau]

One question: shouldn't be the token then populated only if the new argument is true?

IMO is not necessary because actually code use always access_token (similar to odoo/odoo@a55f125#diff-b90ce1ef695264f5890e01458a99eb2b7ab9679df4cfdbec5a0d4c3f156f9e67R54)

[pedrobaeza]

That's not what I'm reading in the link you have passed me, so please follow the same steps as in sale:

• Gather params in the variables and then call to encode_params.
• Don't populate the access token if share_token is False.

[victoralmau]

According to analysis related to _get_share_url() in OCA/contract#680 and test share button, share link and button in mail, my conclusion is that _get_share_url() is not necessary (default functionality is correct in dms use case).

[victoralmau]

It's not necessary now because these changes have apllied in #93 (comment)