[11.0] [MIG] Migrate donation_base #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move from YAML tests to unittest in most modules Use commercial_partner_id for tax receipts (to group tax receipts for a company or a familly) On donation.line, tax_receipt_ok and in_kind are now related stored fields
XML code cleanup (remove fields for which he give the default value)
Adapt the code of other modules for the introduction of donation_sale
Cleanup a few strings
… receipts for invoices
'Account' decimal precision doesn't exist in v10 -> use currency precision Add Eligible tax receipt amount in donation report
Add print button on donation tax receipt form view
Remove @api.multi when not needed PEP8 fixes Replace openerp by odoo
7 tasks
nikul-serpentcs
force-pushed
the
11-donation_base
branch
from
d6d6751
to
1ee405f
Compare
nikul-serpentcs
force-pushed
the
11-donation_base
branch
2 times, most recently
from
4cf3f36
to
b396136
Compare
| self.env['donation.tax.receipt'].update_tax_receipt_annual_dict( | ||
| tax_receipt_annual_dict, self.start_date, self.end_date, | ||
| precision_rounding) | ||
| # {commercial_partner: { |
There was a problem hiding this comment.
Remove dead code
nikul-serpentcs
force-pushed
the
11-donation_base
branch
from
e9d3d85
to
36d5b89
Compare
nikul-serpentcs
force-pushed
the
11-donation_base
branch
from
36d5b89
to
42cfa52
Compare
|
@JayVora-SerpentCS @pedrobaeza @tafaRU Could you please review it? |
alexis-via
approved these changes
Oct 28, 2018
|
I made a rapid review, that's fine for me. There has been several improvements in the 10.0 branch in the meantime, which would be great to up-port, but this can be done in a later PR, I don't want to post-pone this for an up-port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Donation Base
@JayVora-SerpentCS Could you please review it?