[11.0] [MIG] Migrate donation_sale #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt the code of other modules for the introduction of donation_sale
Cleanup a few strings
Fix FR translation
… receipts for invoices
'Account' decimal precision doesn't exist in v10 -> use currency precision Add Eligible tax receipt amount in donation report
Remove @api.multi when not needed PEP8 fixes Replace openerp by odoo
7 tasks
nikul-serpentcs
force-pushed
the
11-donation_sale
branch
from
eb9f304
to
fd609dc
Compare
|
@JayVora-SerpentCS @pedrobaeza @tafaRU @alexis-via Could you please review it? |
JayVora-SerpentCS
suggested changes
Oct 22, 2018
| @@ -0,0 +1,59 @@ | |||
| .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | |||
There was a problem hiding this comment.
Can you use Readme generator plz?
https://github.com/OCA/maintainer-tools/blob/master/tools/gen_addon_readme.py
alexis-via
approved these changes
Oct 28, 2018
|
I made a rapid review, that's fine for me. There has been several improvements in the 10.0 branch in the meantime, which would be great to up-port, but this can be done in a later PR, I don't want to post-pone this for an up-port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Donation Sale
To get some real features, you should install the donation or the donation_sale module.