Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [MIG] donation #68

Closed
wants to merge 114 commits into from

Conversation

nikul-serpentcs
Copy link
Member

Donation

This module handles donations, including in-kind donations. When you validate a donation,
it will create the corresponding accounting entries.

@nikul-serpentcs nikul-serpentcs mentioned this pull request Sep 30, 2019
6 tasks
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general LGTM, but...

donation/models/donation_campaign.py Show resolved Hide resolved
donation/views/donation_campaign.xml Show resolved Hide resolved
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for donation_base

@nikul-serpentcs
Copy link
Member Author

Depend on #67

@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 1, 2019
@alexis-via
Copy link
Contributor

@nikul-serpentcs Thanks for your great work on v12 migration. Could you take into account my last comment on #43, which is what was discussed at the donation table of the OCA code sprint in Louvain la neuve.

@nikul-serpentcs
Copy link
Member Author

@nikul-serpentcs Thanks for your great work on v12 migration. Could you take into account my last comment on #43, which is what was discussed at the donation table of the OCA code sprint in Louvain la neuve.

@alexis-via here We Add simple Donation part when this PR is Merge after in next PR we are Adding a donation_thanks base on discustion. And we create a separate PR for donation_py3o module.

For Second Point I will Add donor boolean on res.partner. So easy to Add the domain in the reconciliation widget.

@@ -30,4 +29,4 @@ def name_get(self):
'Start Date',
default=fields.Date.context_today
)
nota = fields.Text('Notes')
note = fields.Text('Notes')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add oldname='nota'

Alexis de Lattre and others added 18 commits April 27, 2020 13:42
…ed wizard Generate Mass Journal in mass module 3. Fixed a bug in Stay module room name was empty in tree views
…n number may be generated in a sequence per user. By default, number is generated in the donation sequence
… for foreign currencies in donations. Add mass validation wizard (validate mass lines and create account moves) Add conventual information on mass lines. Small usability improvements.
…ass line if certains scenarios Fix a bug when re-validating a donation.
… validation Add "Back to draft" on validated mass transfers
…otal_company_currency on donation.donation Remove view_type from action definition
oca-transbot and others added 16 commits April 27, 2020 13:42
Remove @api.multi when not needed
PEP8 fixes
Replace openerp by odoo
donation_bank_statement: add domain type=bank on donation_credit_transfer_journal_id
donation: Small code improvement on income account selection from product
PEP8 fix
Currently translated at 86.6% (103 of 119 strings)

Translation: donation-11.0/donation-11.0-donation
Translate-URL: https://translation.odoo-community.org/projects/donation-11-0/donation-11-0-donation/de/
Currently translated at 96.6% (115 of 119 strings)

Translation: donation-11.0/donation-11.0-donation
Translate-URL: https://translation.odoo-community.org/projects/donation-11-0/donation-11-0-donation/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: donation-11.0/donation-11.0-donation
Translate-URL: https://translation.odoo-community.org/projects/donation-11-0/donation-11-0-donation/
@jarroyomorales
Copy link

Some time ago I created this svg to replace donation's icon, tell me If your like it and I can propose a PR to this branch or after the migration is done.
@tbaden @nikul-serpentcs

image

@nikul-serpentcs
Copy link
Member Author

Some time ago I created this svg to replace donation's icon, tell me If your like it and I can propose a PR to this branch or after the migration is done.
@tbaden @nikul-serpentcs

image

Good Job @jarroyomorales

I will Add this new logo ASAP.

Thank you

@jarroyomorales
Copy link

@nikul-serpentcs To include it please chery-pick the commit from tegin@0de17f9

@tbaden
Copy link
Member

tbaden commented Jun 18, 2020

@nikul-serpentcs please rebase as donation_base is now available

@jarroyomorales
Copy link

@nikul-serpentcs Can I superseed this?

@nikul-serpentcs
Copy link
Member Author

@nikul-serpentcs Can I superseed this?

Yes Sure

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021
@github-actions github-actions bot closed this Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants