Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [MIG] website_sale_require_legal module #144

Merged
merged 3 commits into from
Jan 6, 2017

Conversation

cubells
Copy link
Member

@cubells cubells commented Nov 28, 2016

  • Updated README.rst

@Tecnativa

@cubells cubells force-pushed the 9.0-mig-website_sale_require_legal branch from b6cfa82 to 9927793 Compare November 28, 2016 11:38
@pedrobaeza pedrobaeza mentioned this pull request Nov 28, 2016
17 tasks
{
"name": "Require accepting legal terms to checkout",
"summary": "Force the user to accept legal tems to buy in the web shop",
"version": "9.0.1.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.0.1.0.0


This module was written to extend the functionality of your website shop to
support forcing the user to accept your legal advice, terms of use and privacy
policy, and allow you to obey some countries' laws.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/obey/comply with

"license": "AGPL-3",
"application": False,
"installable": True,
"external_dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty keys.

@pedrobaeza
Copy link
Member

Please rebase on current 9.0 branch, because I have fixed .travis.yml for allowing sass command.

@cubells
Copy link
Member Author

cubells commented Nov 29, 2016

Is Travis error related to another module?

@pedrobaeza
Copy link
Member

Travis is failing due to website_sale_wishlist module, so not related.

@pedrobaeza
Copy link
Member

Please rebase again, as sass command is still not working.

@cubells cubells force-pushed the 9.0-mig-website_sale_require_legal branch from 63c8203 to bf355e8 Compare November 30, 2016 07:31
@yajo
Copy link
Member

yajo commented Dec 13, 2016

This addon breaks a tour in website_sale_wishlist. You have to fix that tour. It might not be an easy task for tour beginners, should I do that @pedrobaeza?

@pedrobaeza
Copy link
Member

The error is also on base branch, so it's not something of this branch. @yajo, please fix it on another PR.

@yajo
Copy link
Member

yajo commented Dec 13, 2016

I hope #149 and OCA/server-tools#666 fix it.

@yajo
Copy link
Member

yajo commented Dec 22, 2016

You need to rebase.

@cubells cubells force-pushed the 9.0-mig-website_sale_require_legal branch 3 times, most recently from cbd738b to 770a691 Compare December 23, 2016 06:57
@yajo yajo force-pushed the 9.0-mig-website_sale_require_legal branch from 770a691 to 36b20df Compare January 4, 2017 12:08
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a coverage drop, but code & functional test passed.

@pedrobaeza pedrobaeza force-pushed the 9.0-mig-website_sale_require_legal branch from 36b20df to f8cad91 Compare January 5, 2017 21:02
@pedrobaeza pedrobaeza merged commit 926dafc into OCA:9.0 Jan 6, 2017
@yajo yajo deleted the 9.0-mig-website_sale_require_legal branch January 9, 2017 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants