[MIG] website_sale_show_company_data: Migration to 12.0

[victormmtorres]

cc @Tecnativa

[tbaden]

thanks for the work 👍
I did a code review: LGTM

[chienandalu]

Testing on runbot I got this weird behaviour:

[pedrobaeza]

This seems something with website_sale_checkout_country_vat more than with this module. cc @Tardo

[Tardo]

I think that conflicts come from here: https://github.com/odoo/odoo/blob/12.0/addons/website_sale/views/templates.xml#L1283
And others for use t-esc with empty values...

[pedrobaeza]

So it's reproducible without the module?

[Tardo]

@pedrobaeza Yes, without 'website_sale_checkout_country_vat' gets the same behavior

[pedrobaeza]

OK, thanks for the confirmation. @victormmtorres then you should find another way to inject the fields for not conflicting that way.

[victormmtorres]

@chienandalu Please have a check

[chienandalu]

Ok, once runbot is up I'll check it. Did you get to find out if there was an Odoo core bug?

[victormmtorres]

Ok, once runbot is up I'll check it. Did you get to find out if there was an Odoo core bug?

You mean about the VAT no being filled from parent partner? Not sure if it's reported but for sure I could not see this field propagated as soon you edited the parent partner

[victormmtorres]

@chienandalu odoo/odoo#33695

[victormmtorres]

@chienandalu please have a test when have time

[chienandalu]

Looks ok now. The other bug is on Odoo's roof now. Just a tiny thing:

[chienandalu]

You need a blank line in between or it won't be properly formated (you can make a quick test with http://rst.ninjs.org)

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[victormmtorres]

Changes done @chienandalu