Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] website_sale_exception: new module #350

Merged
merged 1 commit into from
May 12, 2020

Conversation

zaoral
Copy link

@zaoral zaoral commented Apr 28, 2020

This module allows to pass a website sale from draft state to sent if there are exeptions that do not let to continue to done state. This is required to close the website sale order after the sale order has been confirmed and the payment has been receive. This way the user can create a new sale order from website without overwritten the last one and without losing the payment information.

@zaoral zaoral marked this pull request as ready for review May 4, 2020 12:29
@zaoral zaoral force-pushed the 12.0-h-26174-kz branch 2 times, most recently from e44d251 to 17e12e3 Compare May 5, 2020 18:55
Copy link

@jjscarafia jjscarafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 technical and functional review

@jjscarafia
Copy link

Anyone using sale_exception consider this interesting?
@ivantodorovich @rvalyi @pedrobaeza @florian-dacosta @sebalix @simahawk
Thanks!

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 12, 2020
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, LGTM 👍

website_sale_exception/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
website_sale_exception/__manifest__.py Outdated Show resolved Hide resolved
@zaoral
Copy link
Author

zaoral commented May 12, 2020

thanks for the review @pedrobaeza @ivantodorovich

@pedrobaeza
Copy link
Member

Can you please squash commits?

@zaoral
Copy link
Author

zaoral commented May 12, 2020

Hi @pedrobaeza
Ready, the commits has been squashed

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-350-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e3580c9 into OCA:12.0 May 12, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 922a052. Thanks a lot for contributing to OCA. ❤️

@jjscarafia jjscarafia deleted the 12.0-h-26174-kz branch May 13, 2020 01:26
@danielduqma danielduqma mentioned this pull request Dec 11, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants