Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] website_sale_attribute_filter_category: Allow to display a category folded or unfolded in website #387

Merged
merged 1 commit into from
Jun 22, 2020
Merged

[12.0][IMP] website_sale_attribute_filter_category: Allow to display a category folded or unfolded in website #387

merged 1 commit into from
Jun 22, 2020

Conversation

sergio-teruel
Copy link

cc @Tecnativa TT24245
Please @CarlosRoca13 @chienandalu Can you review??

@HaraldPanten
Copy link

Hi @sergio-teruel

I was testing your [IMP] but I couldn't see the difference between folding/unfolding the webiste attribute category.

Am I missing something? Could you attach an example, please?

Thx!

chienandalu
chienandalu approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested on runbot

@chienandalu
Copy link
Member

I was testing your [IMP] but I couldn't see the difference between folding/unfolding the webiste attribute category.

Well, it shows the filter folded in the frontend by default. I'd say it's quite self explanatory 😅

folded-unfolded

@sergio-teruel
Copy link
Author

👍 😄

HaraldPanten
HaraldPanten approved these changes Jun 22, 2020
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergio-teruel @chienandalu I wasn't testing it properly. I had the "Product Attribute's filter" disabled. So... I couldn't see any effect. My fault! 👌

Functional review 👍

CarlosRoca13
CarlosRoca13 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot 👍

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-387-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ba520ec into OCA:12.0 Jun 22, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1385e8b. Thanks a lot for contributing to OCA. ❤️

sergio-teruel added a commit to Tecnativa/e-commerce that referenced this pull request Jun 22, 2020
@sergio-teruel
[MIG] website_sale_attribute_filter_category: Migration to v13. Add c…
b70346b 
…ommit (OCA#387)
@sergio-teruel sergio-teruel mentioned this pull request Jun 22, 2020
Merged
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 16, 2023
@sergio-teruel @pilarvargas-tecnativa
[MIG] website_sale_attribute_filter_category: Migration to v13. Add c…
50de6f0 
…ommit (OCA#387)
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 16, 2023
@sergio-teruel @pilarvargas-tecnativa
[MIG] website_sale_attribute_filter_category: Migration to v13. Add c…
3c89477 
…ommit (OCA#387)
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 17, 2023
@sergio-teruel @pilarvargas-tecnativa
[MIG] website_sale_attribute_filter_category: Migration to v13. Add c…
51701d3 
…ommit (OCA#387)
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 24, 2023
@sergio-teruel @pilarvargas-tecnativa
[MIG] website_sale_attribute_filter_category: Migration to v13. Add c…
810f0ee 
…ommit (OCA#387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergio-teruel @HaraldPanten @chienandalu @pedrobaeza @OCA-git-bot @CarlosRoca13