Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] website_sale_attribute_filter_order: Migration to 13.0 #396

Merged
merged 6 commits into from
Jul 13, 2020
Merged

[13.0][MIG] website_sale_attribute_filter_order: Migration to 13.0 #396

merged 6 commits into from
Jul 13, 2020

Conversation

mamcode
Copy link
Member

@mamcode mamcode commented Jul 6, 2020

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @Tardo,
some modules you are maintaining are being modified, check this out!

@mamcode mamcode mentioned this pull request Jul 6, 2020
Closed
22 tasks
HaraldPanten
HaraldPanten approved these changes Jul 13, 2020
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Tardo
Tardo approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza pedrobaeza added this to the 13.0 milestone Jul 13, 2020
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-396-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e0d0e10 into OCA:13.0 Jul 13, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 88de836. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mamcode @OCA-git-bot @pedrobaeza @Tardo @HaraldPanten @oca-travis